Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 248863003: Add a chrome://flags item "allow-insecure-websocket-from-https-origin" (Closed)

Created:
6 years, 8 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Add a chrome://flags item "allow-insecure-websocket-from-https-origin" There're web apps served over HTTPS but are using insecure WebSockets. To improve security, we're going to prohibit that, but should provide an option to turn off the check until everyone finishes fixing their apps to get ready for stopping use of insecure WebSockets from HTTPS origin. The shield page action allows users to manually turn off mixed content check, but for apps designed to open new windows frequently, this workaround is too bothering. So, we'll provide a chrome://flags item which turns off the mixed content check (only for WebSocket). This flag is scheduled to go away when everyone should be ready for accepting this security check. This CL depends on this Blink side CL: https://codereview.chromium.org/246893014/ BUG=85271 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266309

Patch Set 1 #

Patch Set 2 : Addressed #3 but without using RuntimeEnabledFeatures #

Patch Set 3 : Addressed #9 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 8 months ago (2014-04-23 06:34:37 UTC) #1
tyoshino (SeeGerritForStatus)
Blink side CL https://codereview.chromium.org/246893014/
6 years, 8 months ago (2014-04-23 06:56:53 UTC) #2
yhirano
[optional] I like RuntimeEnabledFeatures + WebRuntimeEnabledFeatures + command line switch more than Settings + WebSettings ...
6 years, 8 months ago (2014-04-23 10:07:06 UTC) #3
tyoshino (SeeGerritForStatus)
On 2014/04/23 10:07:06, yhirano wrote: > [optional] I like RuntimeEnabledFeatures + WebRuntimeEnabledFeatures + command > ...
6 years, 8 months ago (2014-04-23 12:48:49 UTC) #4
tyoshino (SeeGerritForStatus)
+jochen
6 years, 8 months ago (2014-04-23 12:57:00 UTC) #5
yhirano
lgtm
6 years, 8 months ago (2014-04-23 13:05:59 UTC) #6
tyoshino (SeeGerritForStatus)
+palmer
6 years, 8 months ago (2014-04-23 13:09:22 UTC) #7
palmer
LGTM
6 years, 8 months ago (2014-04-23 23:45:11 UTC) #8
jochen (gone - plz use gerrit)
lgtm i guess :-/ is there a bug on file to remove this again?
6 years, 8 months ago (2014-04-24 12:51:26 UTC) #9
tyoshino (SeeGerritForStatus)
On 2014/04/24 12:51:26, jochen wrote: > lgtm i guess :-/ > > is there a ...
6 years, 8 months ago (2014-04-24 13:05:51 UTC) #10
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 8 months ago (2014-04-25 03:45:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/248863003/40001
6 years, 8 months ago (2014-04-25 03:45:57 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 08:29:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 08:29:49 UTC) #14
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 8 months ago (2014-04-25 17:56:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/248863003/40001
6 years, 8 months ago (2014-04-25 21:50:31 UTC) #16
commit-bot: I haz the power
Change committed as 266309
6 years, 8 months ago (2014-04-26 00:47:59 UTC) #17
vladi.colton
On 2014/04/26 00:47:59, I haz the power - commit-bot wrote: > Change committed as 266309 ...
5 years, 7 months ago (2015-05-26 12:43:28 UTC) #18
tyoshino (SeeGerritForStatus)
On 2015/05/26 12:43:28, vladi.colton wrote: > On 2014/04/26 00:47:59, I haz the power - commit-bot ...
5 years, 7 months ago (2015-05-26 13:09:10 UTC) #19
vladi.colton
On 2015/05/26 13:09:10, tyoshino wrote: > On 2015/05/26 12:43:28, vladi.colton wrote: > > On 2014/04/26 ...
5 years, 7 months ago (2015-05-27 05:42:45 UTC) #20
tyoshino (SeeGerritForStatus)
5 years, 7 months ago (2015-05-27 06:37:56 UTC) #21
Message was sent while issue was closed.
On 2015/05/27 05:42:45, vladi.colton wrote:
> Thanks a lot,
> Where can i find M42 version for Win OS?

Please take a look at my comments on http://crbug.com/367149

Powered by Google App Engine
This is Rietveld 408576698