Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2488563003: Scroll sticky elements into view. (Closed)

Created:
4 years, 1 month ago by flackr
Modified:
4 years, 1 month ago
Reviewers:
bokan
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scroll sticky elements into view. We specifically ignore elements that scroll with the viewport, but sticky elements should be scrolled into view. BUG=662723 TEST=fast/scroll-behavior/scroll-into-view-sticky.html Committed: https://crrev.com/9e23825d88c48013fb892c755106d21c9aebeeb2 Cr-Commit-Position: refs/heads/master@{#430969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-into-view-sticky.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-into-view-sticky-expected.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
flackr
Hey, It looks like we avoided trying to scroll to position fixed because of course ...
4 years, 1 month ago (2016-11-09 13:00:45 UTC) #2
bokan
Agree matching other browsers for now is best. lgtm.
4 years, 1 month ago (2016-11-09 14:26:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488563003/1
4 years, 1 month ago (2016-11-09 14:31:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 17:54:22 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 18:02:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e23825d88c48013fb892c755106d21c9aebeeb2
Cr-Commit-Position: refs/heads/master@{#430969}

Powered by Google App Engine
This is Rietveld 408576698