Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2488563003: Scroll sticky elements into view. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-into-view-sticky-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 UseTransforms | TraverseDocumentBoundaries) 666 UseTransforms | TraverseDocumentBoundaries)
667 .boundingBox()); 667 .boundingBox());
668 } else { 668 } else {
669 parentBox = nullptr; 669 parentBox = nullptr;
670 } 670 }
671 } 671 }
672 } 672 }
673 } 673 }
674 } 674 }
675 675
676 // If we are fixed-position, it is useless to scroll the parent. 676 // If we are fixed-position and scroll with the viewport, it is useless to
677 if (hasLayer() && layer()->scrollsWithViewport()) 677 // scroll the parent.
678 if (style()->position() == FixedPosition && hasLayer() &&
679 layer()->scrollsWithViewport()) {
678 return; 680 return;
681 }
679 682
680 if (frame()->page()->autoscrollController().autoscrollInProgress()) 683 if (frame()->page()->autoscrollController().autoscrollInProgress())
681 parentBox = enclosingScrollableBox(); 684 parentBox = enclosingScrollableBox();
682 685
683 if (parentBox) 686 if (parentBox)
684 parentBox->scrollRectToVisible(newRect, alignX, alignY, scrollType, 687 parentBox->scrollRectToVisible(newRect, alignX, alignY, scrollType,
685 makeVisibleInVisualViewport); 688 makeVisibleInVisualViewport);
686 } 689 }
687 690
688 void LayoutBox::absoluteRects(Vector<IntRect>& rects, 691 void LayoutBox::absoluteRects(Vector<IntRect>& rects,
(...skipping 4955 matching lines...) Expand 10 before | Expand all | Expand 10 after
5644 LayoutRect rect = frameRect(); 5647 LayoutRect rect = frameRect();
5645 5648
5646 LayoutBlock* block = containingBlock(); 5649 LayoutBlock* block = containingBlock();
5647 if (block) 5650 if (block)
5648 block->adjustChildDebugRect(rect); 5651 block->adjustChildDebugRect(rect);
5649 5652
5650 return rect; 5653 return rect;
5651 } 5654 }
5652 5655
5653 } // namespace blink 5656 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-into-view-sticky-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698