Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2488553002: Fix abspath references in md_browser. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
Reviewers:
jsbell
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix abspath references in md_browser. I thought I had fixed this in the patch to support opening files directly in md_browser, but I got my merges confused. R=jsbell@chromium.org Committed: https://crrev.com/87f634f6b9b2339cbef11a21a8f40eae2a884487 Cr-Commit-Position: refs/heads/master@{#430658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/md_browser/md_browser.py View 4 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 1 month ago (2016-11-08 02:46:52 UTC) #1
jsbell
lgtm
4 years, 1 month ago (2016-11-08 17:17:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488553002/1
4 years, 1 month ago (2016-11-08 18:12:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 18:25:22 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 18:38:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87f634f6b9b2339cbef11a21a8f40eae2a884487
Cr-Commit-Position: refs/heads/master@{#430658}

Powered by Google App Engine
This is Rietveld 408576698