Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: tools/md_browser/md_browser.py

Issue 2488553002: Fix abspath references in md_browser. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/md_browser/md_browser.py
diff --git a/tools/md_browser/md_browser.py b/tools/md_browser/md_browser.py
index 7d293affa9c3fb3f2ca9c2883bc92d0fb0e062c2..43dc5bdc921deae8911c6f72d1152d417d07bc8e 100755
--- a/tools/md_browser/md_browser.py
+++ b/tools/md_browser/md_browser.py
@@ -19,7 +19,7 @@ import time
import webbrowser
-THIS_DIR = os.path.abspath(os.path.dirname(__file__))
+THIS_DIR = os.path.realpath(os.path.dirname(__file__))
SRC_DIR = os.path.dirname(os.path.dirname(THIS_DIR))
sys.path.append(os.path.join(SRC_DIR, 'third_party', 'Python-Markdown'))
import markdown
@@ -34,14 +34,14 @@ def main(argv):
help='open file in browser')
args = parser.parse_args(argv)
- top_level = os.path.abspath(args.directory)
+ top_level = os.path.realpath(args.directory)
s = Server(args.port, top_level)
print('Listening on http://localhost:%s/' % args.port)
thread = None
if args.file:
- path = os.path.abspath(args.file)
+ path = os.path.realpath(args.file)
if not path.startswith(top_level):
print('%s is not under %s' % (args.file, args.directory))
return 1
@@ -108,7 +108,7 @@ class Server(SocketServer.TCPServer):
def __init__(self, port, top_level):
SocketServer.TCPServer.__init__(self, ('0.0.0.0', port), Handler)
self.port = port
- self.top_level = os.path.abspath(top_level)
+ self.top_level = top_level
self.retcode = None
def server_bind(self):
@@ -125,7 +125,7 @@ class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler):
if path.startswith('/chromium/src/+/master'):
path = path[len('/chromium/src/+/master'):]
- full_path = os.path.abspath(os.path.join(self.server.top_level, path[1:]))
+ full_path = os.path.realpath(os.path.join(self.server.top_level, path[1:]))
if not full_path.startswith(self.server.top_level):
self._DoUnknown()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698