Issue 248853002: [NOCOMMIT] Make DriveService{Wrapper|Messenger} class

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+437 lines, -87 lines)			Patch
M	chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/browser/sync_file_system/drive_backend/drive_service_messenger.h	View	1	4 chunks	+42 lines, -21 lines	0 comments	Download
A	chrome/browser/sync_file_system/drive_backend/drive_service_messenger.cc	View	1	1 chunk	+251 lines, -0 lines	0 comments	Download
A	chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.h	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
A	chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.cc	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc	View	1	4 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc	View	1	3 chunks	+14 lines, -13 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine.h	View	1 2 3	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine.cc	View	1 2 3	7 chunks	+31 lines, -13 lines	1 comment	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine_context.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

peria

6 years, 8 months ago (2014-04-24 04:08:37 UTC) #3

https://codereview.chromium.org/248853002/diff/100001/chrome/browser/sync_fil...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/248853002/diff/100001/chrome/browser/sync_fil...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:138: void
SyncEngine::Initialize(const base::FilePath& base_dir,
It may be good to make InitializeForTesting().
In product code, |pass_service_to_worker| must be false and |env_override| must
be NULL.
And we are planning to remove |pass_service_to_worker| argument in the near
future.

Expand Messages | Collapse Messages