Remove WCHAR_T_IS_UNSIGNED definition

Remove the WCHAR_T_IS_UNSIGNED definition since it is not really useful. Replace its use with a static_cast.

BUG=354405
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266058

[rmcilroy, 2014-04-23 18:11:24]

Niko: please take a look, thanks.

[Nico, 2014-04-23 18:18:12]

https://codereview.chromium.org/248843004/diff/1/build/build_config.h
File build/build_config.h (right):

https://codereview.chromium.org/248843004/diff/1/build/build_config.h#newcode143
build/build_config.h:143: #define WCHAR_T_IS_UNSIGNED 1
This looks broken. The only user of this define that I can find,
base/strings/string_util_unittest.cc, only does "#if
defined(WCHAR_T_IS_UNSIGNED)", and doesn't check the value of this define. I
think it's better to delete these 5 lines and change the test to just say
static_cast<wchar_t>(1) (and 2).

wdyt?

[rmcilroy, 2014-04-24 09:58:41]

https://codereview.chromium.org/248843004/diff/1/build/build_config.h
File build/build_config.h (right):

https://codereview.chromium.org/248843004/diff/1/build/build_config.h#newcode143
build/build_config.h:143: #define WCHAR_T_IS_UNSIGNED 1
On 2014/04/23 18:18:12, Nico wrote:
> This looks broken. The only user of this define that I can find,
> base/strings/string_util_unittest.cc, only does "#if
> defined(WCHAR_T_IS_UNSIGNED)", and doesn't check the value of this define. I
> think it's better to delete these 5 lines and change the test to just say
> static_cast<wchar_t>(1) (and 2).
> 
> wdyt?

That sounds much more sensible - done.

[Nico, 2014-04-24 17:32:58]

lgtm with updated change description, thanks :-)

(looks like this was added in https://codereview.chromium.org/99349 and was of
dubious value from the start)

[rmcilroy, 2014-04-24 18:52:42]

On 2014/04/24 17:32:58, Nico wrote:
> lgtm with updated change description, thanks :-)
> 
> (looks like this was added in https://codereview.chromium.org/99349 and was of
> dubious value from the start)

Opps, meant to do that and got distracted :). Done.

Thanks.

[rmcilroy, 2014-04-24 18:52:58]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2014-04-24 21:50:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/248843004/20001

[commit-bot: I haz the power, 2014-04-24 22:56:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:56:03]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Nico, 2014-04-24 23:10:19]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:11:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/248843004/20001

[commit-bot: I haz the power, 2014-04-25 00:08:09]

Change committed as 266058