Remove WCHAR_T_IS_UNSIGNED definition

build/build_config.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file adds defines about the platform we're currently building on.
 //  Operating System:
 //    OS_WIN / OS_MACOSX / OS_LINUX / OS_POSIX (MACOSX or LINUX)
 //  Compiler:
 //    COMPILER_MSVC / COMPILER_GCC
 //  Processor:
@@ skipping 121 matching lines @@
     (__WCHAR_MAX__ == 0x7fff || __WCHAR_MAX__ == 0xffff)
 // On Posix, we'll detect short wchar_t, but projects aren't guaranteed to
 // compile in this mode (in particular, Chrome doesn't). This is intended for
 // other projects using base who manage their own dependencies and make sure
 // short wchar works for them.
 #define WCHAR_T_IS_UTF16
 #else
 #error Please add support for your compiler in build/build_config.h
 #endif
 
-#if defined(__ARMEL__) && !defined(OS_IOS)
+#if (defined(__ARMEL__) || defined(__aarch64__)) && !defined(OS_IOS)
 #define WCHAR_T_IS_UNSIGNED 1

[Nico, 2014/04/23 18:18:12]

This looks broken. The only user of this define that I can find,
base/strings/string_util_unittest.cc, only does "#if
defined(WCHAR_T_IS_UNSIGNED)", and doesn't check the value of this define. I
think it's better to delete these 5 lines and change the test to just say
static_cast<wchar_t>(1) (and 2).

wdyt?

[rmcilroy, 2014/04/24 09:58:41]

That sounds much more sensible - done.

 #elif defined(__MIPSEL__)
 #define WCHAR_T_IS_UNSIGNED 0
 #endif
 
 #if defined(OS_ANDROID)
 // The compiler thinks std::string::const_iterator and "const char*" are
 // equivalent types.
 #define STD_STRING_ITERATOR_IS_CHAR_POINTER
 // The compiler thinks base::string16::const_iterator and "char16*" are
 // equivalent types.
 #define BASE_STRING16_ITERATOR_IS_CHAR16_POINTER
 #endif
 
 #endif  // BUILD_BUILD_CONFIG_H_