Modify WebBluetooth chooser based on UI review feedback

Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

I uploaded a screenshot on the issue page.

BUG=664248
Committed: https://crrev.com/5fc545ee6c46229dbe74c5f0cb406fd938ed4737
Cr-Commit-Position: refs/heads/master@{#431452}

[juncai, 2016-11-10 20:27:24]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 20:27:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-11-10 20:30:04]

Description was changed from

==========
Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

BUG=664248
==========

to

==========
Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

I uploaded a screenshot on the issue page.

BUG=664248
==========

[juncai, 2016-11-10 20:33:18]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org, tedchoc@chromium.org

[juncai, 2016-11-10 20:33:18]

tedchoc@chromium.org: Please review changes in 
//chrome/android/java/strings/android_chrome_strings.grd

rsesek@chromium.org: Please review changes in 
//chrome/browser/ui/cocoa

[commit-bot: I haz the power, 2016-11-10 21:08:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:08:23]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2016-11-10 22:01:08]

LGTM

https://codereview.chromium.org/2488383002/diff/1/chrome/browser/ui/cocoa/cho...
File chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm (right):

https://codereview.chromium.org/2488383002/diff/1/chrome/browser/ui/cocoa/cho...
chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm:887:
[skia::SkColorToCalibratedNSColor(kFootnoteBackgroundColor) setFill];
I'd use +[NSColor colorWithCalibratedWhite:245.0 / 255.0 alpha:1.0] instead, to
avoid the conversion.

[Ted C, 2016-11-10 22:03:40]

On 2016/11/10 22:01:08, Robert Sesek wrote:
> LGTM
> 
>
https://codereview.chromium.org/2488383002/diff/1/chrome/browser/ui/cocoa/cho...
> File chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm (right):
> 
>
https://codereview.chromium.org/2488383002/diff/1/chrome/browser/ui/cocoa/cho...
> chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm:887:
> [skia::SkColorToCalibratedNSColor(kFootnoteBackgroundColor) setFill];
> I'd use +[NSColor colorWithCalibratedWhite:245.0 / 255.0 alpha:1.0] instead,
to
> avoid the conversion.

lgtm - android_chrome_strings.grd

[juncai, 2016-11-10 22:27:49]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 22:28:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-11-10 22:30:39]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 22:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:26:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:26:18]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-11-11 01:46:33]

https://codereview.chromium.org/2488383002/diff/1/chrome/browser/ui/cocoa/cho...
File chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm (right):

https://codereview.chromium.org/2488383002/diff/1/chrome/browser/ui/cocoa/cho...
chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm:887:
[skia::SkColorToCalibratedNSColor(kFootnoteBackgroundColor) setFill];
On 2016/11/10 22:01:08, Robert Sesek wrote:
> I'd use +[NSColor colorWithCalibratedWhite:245.0 / 255.0 alpha:1.0] instead,
to
> avoid the conversion.

Done.

[juncai, 2016-11-11 01:46:40]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-11-11 01:46:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2488383002/#ps40001
(title: "removed unused include file")

[commit-bot: I haz the power, 2016-11-11 01:47:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:52:57]

Description was changed from

==========
Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

I uploaded a screenshot on the issue page.

BUG=664248
==========

to

==========
Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

I uploaded a screenshot on the issue page.

BUG=664248
==========

[commit-bot: I haz the power, 2016-11-11 01:52:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 02:01:00]

Description was changed from

==========
Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

I uploaded a screenshot on the issue page.

BUG=664248
==========

to

==========
Modify WebBluetooth chooser based on UI review feedback

This CL modifies the WebBluetooth chooser in the following:
1. change the "pair with:" to "pair"
   change the "connect to:" to "connect"
2. Change the footnote view background color to grey on Mac to match that
on non-Mac desktops.

I uploaded a screenshot on the issue page.

BUG=664248

Committed: https://crrev.com/5fc545ee6c46229dbe74c5f0cb406fd938ed4737
Cr-Commit-Position: refs/heads/master@{#431452}
==========

[commit-bot: I haz the power, 2016-11-11 02:01:01]

Patchset 3 (id:??) landed as
https://crrev.com/5fc545ee6c46229dbe74c5f0cb406fd938ed4737
Cr-Commit-Position: refs/heads/master@{#431452}