Expose caps lock state as an accessible alert

chrome/browser/ui/ash/chrome_shell_delegate.cc

Index: chrome/browser/ui/ash/chrome_shell_delegate.cc
diff --git a/chrome/browser/ui/ash/chrome_shell_delegate.cc b/chrome/browser/ui/ash/chrome_shell_delegate.cc
index 96f7ad8c785dcd671193f528481026100f707216..de5b79266593a220b2d7efcda21afac850ffaad8 100644
--- a/chrome/browser/ui/ash/chrome_shell_delegate.cc
+++ b/chrome/browser/ui/ash/chrome_shell_delegate.cc
@@ -282,20 +282,30 @@ class AccessibilityDelegateImpl : public ash::AccessibilityDelegate {
     Profile* profile = ProfileManager::GetActiveUserProfile();
     if (profile) {
       switch (alert) {
-        case ash::A11Y_ALERT_WINDOW_NEEDED: {
+        case ash::A11Y_ALERT_CAPS_ON: {

[dmazzoni, 2016/11/10 22:15:18]

How about refactoring this as a concise switch that
gets the message_id of the alert text, and then at the
end of the switch just have one call to HandleAlert.

[oshima, 2016/11/10 22:41:40]

+1

[David Tseng, 2016/11/10 23:46:04]

Done.

           AutomationManagerAura::GetInstance()->HandleAlert(
-              profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_WINDOW_NEEDED));
-          break;
-        }
-        case ash::A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED: {
-          AutomationManagerAura::GetInstance()->HandleAlert(
-              profile, l10n_util::GetStringUTF8(
-                           IDS_A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED));
-          break;
-        }
-        case ash::A11Y_ALERT_NONE:
+              profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_CAPS_ON));
           break;
       }
+      case ash::A11Y_ALERT_CAPS_OFF: {
+        AutomationManagerAura::GetInstance()->HandleAlert(
+            profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_CAPS_OFF));
+        break;
+      }
+      case ash::A11Y_ALERT_WINDOW_NEEDED: {
+        AutomationManagerAura::GetInstance()->HandleAlert(
+            profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_WINDOW_NEEDED));
+        break;
+      }
+      case ash::A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED: {
+        AutomationManagerAura::GetInstance()->HandleAlert(
+            profile, l10n_util::GetStringUTF8(
+                         IDS_A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED));
+        break;
+      }
+      case ash::A11Y_ALERT_NONE:
+        break;
+      }
     }
   }