Expose caps lock state as an accessible alert

chrome/browser/ui/ash/chrome_shell_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/chrome_shell_delegate.h"
 
 #include <stddef.h>
 
 #include <limits>
 
@@ skipping 264 matching lines @@
       return chromeos::MagnificationManager::Get()
           ->GetSavedScreenMagnifierScale();
     }
     return std::numeric_limits<double>::min();
   }
 
   void TriggerAccessibilityAlert(ash::AccessibilityAlert alert) override {
     Profile* profile = ProfileManager::GetActiveUserProfile();
     if (profile) {
       switch (alert) {
-        case ash::A11Y_ALERT_WINDOW_NEEDED: {
+        case ash::A11Y_ALERT_CAPS_ON: {

[dmazzoni, 2016/11/10 22:15:18]

How about refactoring this as a concise switch that
gets the message_id of the alert text, and then at the
end of the switch just have one call to HandleAlert.

[oshima, 2016/11/10 22:41:40]

+1

[David Tseng, 2016/11/10 23:46:04]

Done.

           AutomationManagerAura::GetInstance()->HandleAlert(
-              profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_WINDOW_NEEDED));
+              profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_CAPS_ON));
           break;
-        }
-        case ash::A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED: {
-          AutomationManagerAura::GetInstance()->HandleAlert(
-              profile, l10n_util::GetStringUTF8(
-                           IDS_A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED));
-          break;
-        }
-        case ash::A11Y_ALERT_NONE:
-          break;
+      }
+      case ash::A11Y_ALERT_CAPS_OFF: {
+        AutomationManagerAura::GetInstance()->HandleAlert(
+            profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_CAPS_OFF));
+        break;
+      }
+      case ash::A11Y_ALERT_WINDOW_NEEDED: {
+        AutomationManagerAura::GetInstance()->HandleAlert(
+            profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_WINDOW_NEEDED));
+        break;
+      }
+      case ash::A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED: {
+        AutomationManagerAura::GetInstance()->HandleAlert(
+            profile, l10n_util::GetStringUTF8(
+                         IDS_A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED));
+        break;
+      }
+      case ash::A11Y_ALERT_NONE:
+        break;
       }
     }
   }
 
   ash::AccessibilityAlert GetLastAccessibilityAlert() override {
     return ash::A11Y_ALERT_NONE;
   }
 
   void PlayEarcon(int sound_key) override {
     DCHECK(AccessibilityManager::Get());
@@ skipping 239 matching lines @@
       NOTREACHED() << "Unexpected notification " << type;
   }
 }
 
 void ChromeShellDelegate::PlatformInit() {
   registrar_.Add(this, chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED,
                  content::NotificationService::AllSources());
   registrar_.Add(this, chrome::NOTIFICATION_SESSION_STARTED,
                  content::NotificationService::AllSources());
 }