Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 24883002: Uses and returns the fractional width in text eliding (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix round-down problems Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
index 43f5a1dc7b5b558941424ebc7c94031fe94d3999..f82b25968458bd63f88c6ebd97fadb05a4ed4d7d 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h
@@ -91,9 +91,9 @@ class AutofillPopupControllerImpl : public AutofillPopupController {
virtual int GetIconResourceID(const string16& resource_name) OVERRIDE;
virtual bool CanDelete(size_t index) const OVERRIDE;
virtual bool IsWarning(size_t index) const OVERRIDE;
- virtual gfx::Rect GetRowBounds(size_t index) OVERRIDE;
- virtual void SetPopupBounds(const gfx::Rect& bounds) OVERRIDE;
- virtual const gfx::Rect& popup_bounds() const OVERRIDE;
+ virtual gfx::RectF GetRowBounds(size_t index) OVERRIDE;
+ virtual void SetPopupBounds(const gfx::RectF& bounds) OVERRIDE;
+ virtual const gfx::RectF& popup_bounds() const OVERRIDE;
virtual gfx::NativeView container_view() const OVERRIDE;
virtual const gfx::RectF& element_bounds() const OVERRIDE;
virtual bool IsRTL() const OVERRIDE;
@@ -152,7 +152,7 @@ class AutofillPopupControllerImpl : public AutofillPopupController {
// Protected so tests can access.
#if !defined(OS_ANDROID)
// Calculates the desired width of the popup based on its contents.
- int GetDesiredPopupWidth() const;
+ float GetDesiredPopupWidth() const;
// Calculates the desired height of the popup based on its contents.
int GetDesiredPopupHeight() const;
@@ -183,10 +183,10 @@ class AutofillPopupControllerImpl : public AutofillPopupController {
// Calculates the width of the popup and the x position of it. These values
// will stay on the screen.
- std::pair<int, int> CalculatePopupXAndWidth(
+ std::pair<float, float> CalculatePopupXAndWidth(
const gfx::Display& left_display,
const gfx::Display& right_display,
- int popup_required_width) const;
+ float popup_required_width) const;
// Calculates the height of the popup and the y position of it. These values
// will stay on the screen.
@@ -204,7 +204,7 @@ class AutofillPopupControllerImpl : public AutofillPopupController {
const gfx::RectF element_bounds_;
// The bounds of the Autofill popup.
- gfx::Rect popup_bounds_;
+ gfx::RectF popup_bounds_;
// The text direction of the popup.
base::i18n::TextDirection text_direction_;

Powered by Google App Engine
This is Rietveld 408576698