Uses and returns the fractional width in text eliding

chrome/browser/ui/autofill/autofill_popup_controller.h

Index: chrome/browser/ui/autofill/autofill_popup_controller.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller.h b/chrome/browser/ui/autofill/autofill_popup_controller.h
index 4b4f7c6d8f540ce1d031f13100dc8f35b77504df..908e76afc71168352ca669bff51e75ad54bb7f12 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller.h
@@ -63,14 +63,14 @@ class AutofillPopupController {
   virtual bool IsWarning(size_t index) const = 0;
 
   // Updates the bounds of the popup and initiates a redraw.
-  virtual void SetPopupBounds(const gfx::Rect& bounds) = 0;
+  virtual void SetPopupBounds(const gfx::RectF& bounds) = 0;

[sky, 2013/10/03 14:19:23]

Why do any of the changes in this file require floats? Bounds should always end
up as ints, right?

[jianli, 2013/10/03 18:42:17]

On Mac, bounds are represented as floats underneath. Since these auto-fill popup
bounds are computed based on string width, we should try to return float bounds
in order to avoid possible round-down. Otherwise, it could be possible that the
truncated bounds add up with other truncated bounds which could cause the
problem.

 
   // Returns the bounds of the item at |index| in the popup, relative to
   // the top left of the popup.
-  virtual gfx::Rect GetRowBounds(size_t index) = 0;
+  virtual gfx::RectF GetRowBounds(size_t index) = 0;
 
   // The actual bounds of the popup.
-  virtual const gfx::Rect& popup_bounds() const = 0;
+  virtual const gfx::RectF& popup_bounds() const = 0;
 
   // The view that the form field element sits in.
   virtual gfx::NativeView container_view() const = 0;