|
|
Revert of mojo VR interface simplified (patchset #21 id:400001 of https://codereview.chromium.org/2420743003/ )
Reason for revert:
This broke https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5867/steps/compile/logs/stdio
Original issue's description:
> mojo VR interface simplified
>
> Since mojo interface prefer API without index transfer, current
> implementation should be modified.
>
> According to dcheng@ and bajones@ comments, WebVR implementation should
> modified to let display/frame communicate directly so that index
> parameters are no longer need.
>
> This patch is based on the strategy above and will have three stages:
> 1(done). Modify event handler part;
> 2(current). Modify VRService Interface;
> 3. Modify unittest part;
>
> BUG= 652080
> R=leon.han@intel.com,dcheng@chromium.org,bshe@chromium.org,bajones@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/91d0e2e835b7e000e432f3df690ed37a36cde1ec
> Cr-Commit-Position: refs/heads/master@{#431210}
TBR=bajones@chromium.org,bshe@chromium.org,dcheng@chromium.org,leon.han@intel.com,reillyg@chromium.org,rockot@chromium.org,haraken@chromium.org,clamy@chromium.org,mkwst@chromium.org,shaobo.yan@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 652080
Committed: https://crrev.com/f9f3bc1775dff0c89c8feb0737e36e71a9ae0658
Cr-Commit-Position: refs/heads/master@{#431233}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+777 lines, -615 lines) |
Patch |
 |
M |
content/browser/frame_host/render_frame_host_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/public/app/mojo/content_browser_manifest.json
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
device/vr/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
device/vr/android/gvr/gvr_device.h
|
View
|
|
1 chunk |
+8 lines, -9 lines |
0 comments
|
Download
|
 |
M |
device/vr/android/gvr/gvr_device.cc
|
View
|
|
5 chunks |
+26 lines, -47 lines |
0 comments
|
Download
|
 |
M |
device/vr/android/gvr/gvr_device_provider.h
|
View
|
|
3 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
device/vr/android/gvr/gvr_device_provider.cc
|
View
|
|
3 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
device/vr/test/fake_vr_device.h
|
View
|
|
1 chunk |
+8 lines, -15 lines |
0 comments
|
Download
|
 |
M |
device/vr/test/fake_vr_device.cc
|
View
|
|
4 chunks |
+15 lines, -27 lines |
0 comments
|
Download
|
 |
A |
device/vr/vr_client_dispatcher.h
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_device.h
|
View
|
|
2 chunks |
+8 lines, -33 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_device.cc
|
View
|
|
2 chunks |
+2 lines, -43 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_device_manager.h
|
View
|
|
3 chunks |
+24 lines, -3 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_device_manager.cc
|
View
|
|
8 chunks |
+176 lines, -21 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_device_manager_unittest.cc
|
View
|
|
4 chunks |
+25 lines, -14 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_device_provider.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
D |
device/vr/vr_display_impl.h
|
View
|
|
1 chunk |
+0 lines, -47 lines |
0 comments
|
Download
|
 |
D |
device/vr/vr_display_impl.cc
|
View
|
|
1 chunk |
+0 lines, -49 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_service.mojom
|
View
|
|
2 chunks |
+29 lines, -35 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_service_impl.h
|
View
|
|
1 chunk |
+18 lines, -18 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_service_impl.cc
|
View
|
|
1 chunk |
+51 lines, -30 lines |
0 comments
|
Download
|
 |
M |
device/vr/vr_service_impl_unittest.cc
|
View
|
|
5 chunks |
+117 lines, -26 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRController.h
|
View
|
|
1 chunk |
+26 lines, -13 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRController.cpp
|
View
|
|
2 chunks |
+174 lines, -64 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRDisplay.h
|
View
|
|
6 chunks |
+3 lines, -22 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRDisplay.cpp
|
View
|
|
13 chunks |
+16 lines, -85 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VREyeParameters.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VREyeParameters.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRFrameData.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRFrameData.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRPose.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRPose.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRStageParameters.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRStageParameters.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|