Revert of mojo VR interface simplified

device/vr/vr_device_manager_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/vr/vr_device_manager.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/macros.h"
@@ skipping 14 matching lines @@
 
   bool HasServiceInstance() { return VRDeviceManager::HasInstance(); }
 
   VRDevice* GetDevice(unsigned int index) {
     return device_manager_->GetDevice(index);
   }
 
  protected:
   FakeVRDeviceProvider* provider_;
   std::unique_ptr<VRDeviceManager> device_manager_;
-  std::unique_ptr<VRServiceImpl> vr_service_;
 
   DISALLOW_COPY_AND_ASSIGN(VRDeviceManagerTest);
 };
 
 VRDeviceManagerTest::VRDeviceManagerTest() {}
 
 VRDeviceManagerTest::~VRDeviceManagerTest() {}
 
 void VRDeviceManagerTest::SetUp() {
   std::unique_ptr<FakeVRDeviceProvider> provider(new FakeVRDeviceProvider());
   provider_ = provider.get();
   device_manager_.reset(new VRDeviceManager(std::move(provider)));
-  vr_service_.reset(new VRServiceImpl());
 }
 
 TEST_F(VRDeviceManagerTest, InitializationTest) {
   EXPECT_FALSE(provider_->IsInitialized());
 
   // Calling GetDevices should initialize the service if it hasn't been
   // initialized yet or the providesr have been released.
   // The mojom::VRService should initialize each of it's providers upon it's own
   // initialization.
-  device_manager_->GetVRDevices(vr_service_.get());
+  mojo::Array<VRDisplayPtr> webvr_devices;
+  webvr_devices = device_manager_->GetVRDevices();
   EXPECT_TRUE(provider_->IsInitialized());
 }
 
 TEST_F(VRDeviceManagerTest, GetDevicesBasicTest) {
-  bool success = device_manager_->GetVRDevices(vr_service_.get());
+  mojo::Array<VRDisplayPtr> webvr_devices;
+  webvr_devices = device_manager_->GetVRDevices();
   // Calling GetVRDevices should initialize the providers.
   EXPECT_TRUE(provider_->IsInitialized());
-  EXPECT_FALSE(success);
+  // Should successfully return zero devices when none are available.
+  EXPECT_EQ(0u, webvr_devices.size());
 
   // GetDeviceByIndex should return nullptr if an invalid index in queried.
   VRDevice* queried_device = GetDevice(1);
   EXPECT_EQ(nullptr, queried_device);
 
   std::unique_ptr<FakeVRDevice> device1(new FakeVRDevice(provider_));
   provider_->AddDevice(device1.get());
-  success = device_manager_->GetVRDevices(vr_service_.get());
-  EXPECT_TRUE(success);
+  webvr_devices = device_manager_->GetVRDevices();
   // Should have successfully returned one device.
-  EXPECT_EQ(device1.get(), GetDevice(device1->id()));
+  EXPECT_EQ(1u, webvr_devices.size());
+  // The WebVRDevice index should match the device id.
+  EXPECT_EQ(webvr_devices[0]->index, device1->id());
 
   std::unique_ptr<FakeVRDevice> device2(new FakeVRDevice(provider_));
   provider_->AddDevice(device2.get());
-  success = device_manager_->GetVRDevices(vr_service_.get());
-  EXPECT_TRUE(success);
+  webvr_devices = device_manager_->GetVRDevices();
+  // Should have successfully returned two devices.
+  EXPECT_EQ(2u, webvr_devices.size());
+  // NOTE: Returned WebVRDevices are not required to be in any particular order.
 
   // Querying the WebVRDevice index should return the correct device.
-  VRDevice* queried_device1 = GetDevice(device1->id());
-  EXPECT_EQ(device1.get(), queried_device1);
-  VRDevice* queried_device2 = GetDevice(device2->id());
-  EXPECT_EQ(device2.get(), queried_device2);
+  queried_device = GetDevice(device1->id());
+  EXPECT_EQ(device1.get(), queried_device);
+  queried_device = GetDevice(device2->id());
+  EXPECT_EQ(device2.get(), queried_device);
+
+  provider_->RemoveDevice(device1.get());
+  webvr_devices = device_manager_->GetVRDevices();
+  // Should have successfully returned one device.
+  EXPECT_EQ(1u, webvr_devices.size());
+  // The WebVRDevice index should match the only remaining device id.
+  EXPECT_EQ(webvr_devices[0]->index, device2->id());
 }
 
 }  // namespace device