Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2488173005: Adding support for exclude locales to variations. (Closed)

Created:
4 years, 1 month ago by jwd
Modified:
4 years, 1 month ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding support for exclude locales to variations. BUG=664682 Committed: https://crrev.com/1db68a10877c1732b26473581ce0b8866be6fbda Cr-Commit-Position: refs/heads/master@{#431722}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M components/variations/proto/study.proto View 1 3 chunks +10 lines, -3 lines 0 comments Download
M components/variations/study_filtering.cc View 1 1 chunk +10 lines, -7 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 2 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
jwd
4 years, 1 month ago (2016-11-11 20:22:38 UTC) #3
rkaplow
lgtm nit, you probably should have a crbug associated https://codereview.chromium.org/2488173005/diff/1/components/variations/study_filtering.cc File components/variations/study_filtering.cc (right): https://codereview.chromium.org/2488173005/diff/1/components/variations/study_filtering.cc#newcode113 components/variations/study_filtering.cc:113: ...
4 years, 1 month ago (2016-11-11 21:21:10 UTC) #7
jwd
https://codereview.chromium.org/2488173005/diff/1/components/variations/study_filtering.cc File components/variations/study_filtering.cc (right): https://codereview.chromium.org/2488173005/diff/1/components/variations/study_filtering.cc#newcode113 components/variations/study_filtering.cc:113: // Check if we are spposed to filter for ...
4 years, 1 month ago (2016-11-12 00:21:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488173005/20001
4 years, 1 month ago (2016-11-12 00:22:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 01:23:20 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 01:26:16 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1db68a10877c1732b26473581ce0b8866be6fbda
Cr-Commit-Position: refs/heads/master@{#431722}

Powered by Google App Engine
This is Rietveld 408576698