Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: components/variations/proto/study.proto

Issue 2488173005: Adding support for exclude locales to variations. (Closed)
Patch Set: fix typo in comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/variations/study_filtering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/proto/study.proto
diff --git a/components/variations/proto/study.proto b/components/variations/proto/study.proto
index 72afc1adbd7c77d889eed1b03dd560a17a2eb72f..d880a0075d4f91abf36fada1e359e565c562c58b 100644
--- a/components/variations/proto/study.proto
+++ b/components/variations/proto/study.proto
@@ -198,7 +198,7 @@ message Study {
// Filtering criteria specifying whether this study is applicable to a given
// Chrome instance.
//
- // Next tag: 12
+ // Next tag: 13
message Filter {
// The start date of the study in Unix time format. (Seconds since midnight
// January 1, 1970 UTC). See: http://en.wikipedia.org/wiki/Unix_time
@@ -230,10 +230,17 @@ message Study {
repeated Platform platform = 5;
// List of locales that will receive this study. If omitted, the study
- // applies to all locales.
+ // applies to all locales, unless |exclude_locale| is specified. Mutually
+ // exclusive with |exclude_locale|.
// Ex: ["en-US", "en-CA"]
repeated string locale = 6;
+ // List of locales that will be excluded from this study. If omitted, the
+ // study applies to all locales unless |locale| is specified. Mutually
+ // exclusive with |locale|.
+ // Ex: ["en-US", "en-CA"]
+ repeated string exclude_locale = 12;
+
// List of form factors that will receive this study. If omitted, the study
// applies to all form factors.
// Ex: [PHONE, TABLET]
@@ -265,7 +272,7 @@ message Study {
repeated string country = 10;
// List of lowercase ISO 3166-1 alpha-2 country codes that will be excluded
- // in this study. If omitted, the study applies to all countries unless
+ // from this study. If omitted, the study applies to all countries unless
// |country| is specified. Mutually exclusive with |country|.
// Ex: ["in", "us"]
repeated string exclude_country = 11;
« no previous file with comments | « no previous file | components/variations/study_filtering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698