Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/test/context_manager_test.dart

Issue 2488043002: Enable generic method support by default (Closed)
Patch Set: clean up Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/context_manager_test.dart
diff --git a/pkg/analysis_server/test/context_manager_test.dart b/pkg/analysis_server/test/context_manager_test.dart
index ce0bf7dbb758f00f1d6b1f274d3f3e34477fc98a..671a132fae4551d2ff72d78f65fbfdb2de1b1ea6 100644
--- a/pkg/analysis_server/test/context_manager_test.dart
+++ b/pkg/analysis_server/test/context_manager_test.dart
@@ -1851,7 +1851,7 @@ embedded_libs:
"dart:foobar": "../sdk_ext/entry.dart"
analyzer:
language:
- enableGenericMethods: true
+ enableStrictCallChecks: true
errors:
unused_local_variable: false
linter:
@@ -1866,7 +1866,7 @@ linter:
// Verify options were set.
expect(errorProcessors, hasLength(1));
expect(lints, hasLength(1));
- expect(options.enableGenericMethods, isTrue);
+ expect(options.enableStrictCallChecks, isTrue);
// Remove options.
deleteFile([projPath, optionsFileName]);
@@ -1875,7 +1875,7 @@ linter:
// Verify defaults restored.
expect(errorProcessors, isEmpty);
expect(lints, isEmpty);
- expect(options.enableGenericMethods, isFalse);
+ expect(options.enableStrictCallChecks, isFalse);
}
test_analysis_options_file_delete_with_embedder() async {
@@ -1905,7 +1905,7 @@ test_pack:lib/''');
r'''
analyzer:
language:
- enableGenericMethods: true
+ enableStrictCallChecks: true
errors:
unused_local_variable: false
linter:
@@ -1918,7 +1918,7 @@ linter:
await pumpEventQueue();
// Verify options were set.
- expect(options.enableGenericMethods, isTrue);
+ expect(options.enableStrictCallChecks, isTrue);
expect(options.strongMode, isTrue);
expect(errorProcessors, hasLength(2));
expect(lints, hasLength(2));
@@ -1928,7 +1928,7 @@ linter:
await pumpEventQueue();
// Verify defaults restored.
- expect(options.enableGenericMethods, isFalse);
+ expect(options.enableStrictCallChecks, isFalse);
expect(lints, hasLength(1));
expect(lints.first, new isInstanceOf<AvoidAs>());
expect(errorProcessors, hasLength(1));
@@ -1997,7 +1997,7 @@ analyzer:
exclude:
- 'test/**'
language:
- enableGenericMethods: true
+ enableStrictCallChecks: true
errors:
unused_local_variable: false
linter:
@@ -2022,7 +2022,7 @@ linter:
expect(context.analysisOptions.strongMode, isTrue);
expect(context.analysisOptions.enableSuperMixins, isTrue);
// * from analysis options:
- expect(context.analysisOptions.enableGenericMethods, isTrue);
+ expect(context.analysisOptions.enableStrictCallChecks, isTrue);
// * verify tests are excluded
expect(callbacks.currentContextFilePaths[projPath].keys,
@@ -2093,7 +2093,7 @@ analyzer:
exclude:
- 'test/**'
language:
- enableGenericMethods: true
+ enableStrictCallChecks: true
errors:
unused_local_variable: false
linter:
@@ -2129,7 +2129,7 @@ linter:
expect(context.analysisOptions.strongMode, isTrue);
expect(context.analysisOptions.enableSuperMixins, isTrue);
// * from analysis options:
- expect(context.analysisOptions.enableGenericMethods, isTrue);
+ expect(context.analysisOptions.enableStrictCallChecks, isTrue);
// * verify tests are excluded
expect(
@@ -2202,7 +2202,7 @@ analyzer:
exclude:
- 'test/**'
language:
- enableGenericMethods: true
+ enableStrictCallChecks: true
errors:
unused_local_variable: false
linter:
@@ -2226,7 +2226,7 @@ linter:
expect(context.analysisOptions.strongMode, isTrue);
expect(context.analysisOptions.enableSuperMixins, isTrue);
// * from analysis options:
- expect(context.analysisOptions.enableGenericMethods, isTrue);
+ expect(context.analysisOptions.enableStrictCallChecks, isTrue);
// * verify tests are excluded
expect(
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698