Enable generic method support by default

pkg/analysis_server/test/context_manager_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.context.directory.manager;
 
 import 'dart:collection';
 
 import 'package:analysis_server/src/context_manager.dart';
 import 'package:analyzer/error/error.dart';
@@ skipping 1833 matching lines @@
 
   test_analysis_options_file_delete() async {
     // Setup analysis options
     newFile(
         [projPath, optionsFileName],
         r'''
 embedded_libs:
   "dart:foobar": "../sdk_ext/entry.dart"
 analyzer:
   language:
-    enableGenericMethods: true
+    enableStrictCallChecks: true
   errors:
     unused_local_variable: false
 linter:
   rules:
     - camel_case_types
 ''');
 
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
     await pumpEventQueue();
 
     // Verify options were set.
     expect(errorProcessors, hasLength(1));
     expect(lints, hasLength(1));
-    expect(options.enableGenericMethods, isTrue);
+    expect(options.enableStrictCallChecks, isTrue);
 
     // Remove options.
     deleteFile([projPath, optionsFileName]);
     await pumpEventQueue();
 
     // Verify defaults restored.
     expect(errorProcessors, isEmpty);
     expect(lints, isEmpty);
-    expect(options.enableGenericMethods, isFalse);
+    expect(options.enableStrictCallChecks, isFalse);
   }
 
   test_analysis_options_file_delete_with_embedder() async {
     // Setup _embedder.yaml.
     String libPath = newFolder([projPath, ContextManagerTest.LIB_NAME]);
     newFile(
         [libPath, '_embedder.yaml'],
         r'''
 analyzer:
   strong-mode: true
   errors:
     missing_return: false
 linter:
   rules:
     - avoid_as
 ''');
 
     // Setup .packages file
     newFile(
         [projPath, '.packages'],
         r'''
 test_pack:lib/''');
 
     // Setup analysis options
     newFile(
         [projPath, optionsFileName],
         r'''
 analyzer:
   language:
-    enableGenericMethods: true
+    enableStrictCallChecks: true
   errors:
     unused_local_variable: false
 linter:
   rules:
     - camel_case_types
 ''');
 
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
     await pumpEventQueue();
 
     // Verify options were set.
-    expect(options.enableGenericMethods, isTrue);
+    expect(options.enableStrictCallChecks, isTrue);
     expect(options.strongMode, isTrue);
     expect(errorProcessors, hasLength(2));
     expect(lints, hasLength(2));
 
     // Remove options.
     deleteFile([projPath, optionsFileName]);
     await pumpEventQueue();
 
     // Verify defaults restored.
-    expect(options.enableGenericMethods, isFalse);
+    expect(options.enableStrictCallChecks, isFalse);
     expect(lints, hasLength(1));
     expect(lints.first, new isInstanceOf<AvoidAs>());
     expect(errorProcessors, hasLength(1));
     expect(getProcessor(missing_return).severity, isNull);
   }
 
   test_analysis_options_parse_failure() async {
     // Create files.
     String libPath = newFolder([projPath, ContextManagerTest.LIB_NAME]);
     newFile([libPath, 'main.dart']);
@@ skipping 48 matching lines @@
 ''');
 
     // Setup analysis options
     newFile(
         [projPath, optionsFileName],
         r'''
 analyzer:
   exclude:
     - 'test/**'
   language:
-    enableGenericMethods: true
+    enableStrictCallChecks: true
   errors:
     unused_local_variable: false
 linter:
   rules:
     - camel_case_types
 ''');
 
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
     await pumpEventQueue();
 
     // Confirm that one context was created.
     var contexts =
         manager.contextsInAnalysisRoot(resourceProvider.newFolder(projPath));
     expect(contexts, isNotNull);
     expect(contexts, hasLength(1));
 
     var context = contexts.first;
 
     // Verify options.
     // * from `config.yaml`:
     expect(context.analysisOptions.strongMode, isTrue);
     expect(context.analysisOptions.enableSuperMixins, isTrue);
     // * from analysis options:
-    expect(context.analysisOptions.enableGenericMethods, isTrue);
+    expect(context.analysisOptions.enableStrictCallChecks, isTrue);
 
     // * verify tests are excluded
     expect(callbacks.currentContextFilePaths[projPath].keys,
         unorderedEquals(['/my/proj/$optionsFileName']));
 
     // Verify filter setup.
     expect(errorProcessors, hasLength(2));
 
     // * (config.)
     expect(getProcessor(missing_return).severity, isNull);
@@ skipping 50 matching lines @@
 test_pack:lib/''');
 
     // Setup analysis options
     newFile(
         [projPath, optionsFileName],
         r'''
 analyzer:
   exclude:
     - 'test/**'
   language:
-    enableGenericMethods: true
+    enableStrictCallChecks: true
   errors:
     unused_local_variable: false
 linter:
   rules:
     - camel_case_types
 ''');
 
     // Setup config.yaml.
     newFile(
         [libPath, 'config', 'config.yaml'],
@@ skipping 15 matching lines @@
         manager.contextsInAnalysisRoot(resourceProvider.newFolder(projPath));
     expect(contexts, isNotNull);
     expect(contexts, hasLength(1));
     var context = contexts[0];
 
     // Verify options.
     // * from `_embedder.yaml`:
     expect(context.analysisOptions.strongMode, isTrue);
     expect(context.analysisOptions.enableSuperMixins, isTrue);
     // * from analysis options:
-    expect(context.analysisOptions.enableGenericMethods, isTrue);
+    expect(context.analysisOptions.enableStrictCallChecks, isTrue);
 
     // * verify tests are excluded
     expect(
         callbacks.currentContextFilePaths[projPath].keys,
         unorderedEquals(
             ['/my/proj/sdk_ext/entry.dart', '/my/proj/$optionsFileName']));
 
     // Verify filter setup.
     expect(errorProcessors, hasLength(3));
 
@@ skipping 52 matching lines @@
 test_pack:lib/''');
 
     // Setup analysis options
     newFile(
         [projPath, optionsFileName],
         r'''
 analyzer:
   exclude:
     - 'test/**'
   language:
-    enableGenericMethods: true
+    enableStrictCallChecks: true
   errors:
     unused_local_variable: false
 linter:
   rules:
     - camel_case_types
 ''');
 
     // Setup context.
     manager.setRoots(<String>[projPath], <String>[], <String, String>{});
     await pumpEventQueue();
 
     // Confirm that one context was created.
     var contexts =
         manager.contextsInAnalysisRoot(resourceProvider.newFolder(projPath));
     expect(contexts, isNotNull);
     expect(contexts, hasLength(1));
     var context = contexts[0];
 
     // Verify options.
     // * from `_embedder.yaml`:
     expect(context.analysisOptions.strongMode, isTrue);
     expect(context.analysisOptions.enableSuperMixins, isTrue);
     // * from analysis options:
-    expect(context.analysisOptions.enableGenericMethods, isTrue);
+    expect(context.analysisOptions.enableStrictCallChecks, isTrue);
 
     // * verify tests are excluded
     expect(
         callbacks.currentContextFilePaths[projPath].keys,
         unorderedEquals(
             ['/my/proj/sdk_ext/entry.dart', '/my/proj/$optionsFileName']));
 
     // Verify filter setup.
     expect(errorProcessors, hasLength(2));
 
@@ skipping 527 matching lines @@
 class TestUriResolver extends UriResolver {
   Map<Uri, Source> uriMap;
 
   TestUriResolver(this.uriMap);
 
   @override
   Source resolveAbsolute(Uri uri, [Uri actualUri]) {
     return uriMap[uri];
   }
 }