chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc - Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc

Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status. (Closed)

Patch Set: Address comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h ('k') | chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc

index 7f1e3028dca558639bcb31b100ac1090d4b45355..323ad0e619383fe00ce6587a5f6505ea36bcb0e2 100644

--- a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc

+++ b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc

@@ -72,10 +72,6 @@ void AppWindowLauncherItemController::SetActiveWindow(aura::Window* window) {

last_active_window_ = app_window;

}

-bool AppWindowLauncherItemController::IsOpen() const {

- return !windows_.empty();

bool AppWindowLauncherItemController::IsVisible() const {

// Return true if any windows are visible.

for (const auto* window : windows_) {