chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h - Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h

Issue 2487953003: Remove LauncherItemController::IsOpen, check ShelfItem::status. (Closed)

Patch Set: Address comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc ('k') | chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h

diff --git a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h

index b024dd806ac326b16279afbcce1f876a0c67371f..7cee485851a3ea2c6f49c403f69bc434ca3e63df 100644

--- a/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h

+++ b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h

@@ -46,7 +46,6 @@ class AppWindowLauncherItemController : public LauncherItemController,

const std::string& launch_id() const { return launch_id_; }

// LauncherItemController overrides:

- bool IsOpen() const override;

bool IsVisible() const override;

void Launch(ash::LaunchSource source, int event_flags) override;

ash::ShelfItemDelegate::PerformedAction Activate(