Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Issue 2487913002: Remove InterpolableBool and existing use of it in SVG path interpolation (Closed)

Created:
4 years, 1 month ago by alancutter (OOO until 2018)
Modified:
4 years, 1 month ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove InterpolableBool and existing use of it in SVG path interpolation The InterpolableBool class should not be used as bools are not considered interpolable. This change replaces the single use of it with InterpolableNumber. This retains the existing behaviour but is not ideal. This change fixes a nullptr crash caused by the use of InterpolableBool. BUG=662694 Committed: https://crrev.com/2439d975210aba96119d8b75633b9f5659563d00 Cr-Commit-Position: refs/heads/master@{#430907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -73 lines) Patch
A third_party/WebKit/LayoutTests/animations/d-path-neutral-value-crash.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 2 chunks +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValueTest.cpp View 4 chunks +3 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
alancutter (OOO until 2018)
4 years, 1 month ago (2016-11-09 06:41:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487913002/1
4 years, 1 month ago (2016-11-09 10:43:01 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-09 10:43:05 UTC) #10
Eric Willigers
lgtm
4 years, 1 month ago (2016-11-09 11:02:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487913002/1
4 years, 1 month ago (2016-11-09 11:03:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 11:06:53 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 11:08:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2439d975210aba96119d8b75633b9f5659563d00
Cr-Commit-Position: refs/heads/master@{#430907}

Powered by Google App Engine
This is Rietveld 408576698