Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/animation/InterpolableValue.h

Issue 2487913002: Remove InterpolableBool and existing use of it in SVG path interpolation (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/InterpolableValue.h
diff --git a/third_party/WebKit/Source/core/animation/InterpolableValue.h b/third_party/WebKit/Source/core/animation/InterpolableValue.h
index 6344f047b7919500fcc287278fce96382d11ecb8..af3b7209e161707a2a845520c375183eb8ab86a4 100644
--- a/third_party/WebKit/Source/core/animation/InterpolableValue.h
+++ b/third_party/WebKit/Source/core/animation/InterpolableValue.h
@@ -78,39 +78,6 @@ class CORE_EXPORT InterpolableNumber final : public InterpolableValue {
explicit InterpolableNumber(double value) : m_value(value) {}
};
-class CORE_EXPORT InterpolableBool final : public InterpolableValue {
- public:
- static std::unique_ptr<InterpolableBool> create(bool value) {
- return wrapUnique(new InterpolableBool(value));
- }
-
- bool isBool() const final { return true; }
- bool value() const { return m_value; }
- bool equals(const InterpolableValue&) const final {
- NOTREACHED();
- return false;
- }
- std::unique_ptr<InterpolableValue> clone() const final {
- return create(m_value);
- }
- std::unique_ptr<InterpolableValue> cloneAndZero() const final {
- NOTREACHED();
- return nullptr;
- }
- void scale(double scale) final { NOTREACHED(); }
- void scaleAndAdd(double scale, const InterpolableValue& other) final {
- NOTREACHED();
- }
-
- private:
- void interpolate(const InterpolableValue& to,
- const double progress,
- InterpolableValue& result) const final;
- bool m_value;
-
- explicit InterpolableBool(bool value) : m_value(value) {}
-};
-
class CORE_EXPORT InterpolableList : public InterpolableValue {
public:
// Explicitly delete operator= because MSVC automatically generate
@@ -204,11 +171,6 @@ DEFINE_TYPE_CASTS(InterpolableNumber,
value,
value->isNumber(),
value.isNumber());
-DEFINE_TYPE_CASTS(InterpolableBool,
- InterpolableValue,
- value,
- value->isBool(),
- value.isBool());
DEFINE_TYPE_CASTS(InterpolableList,
InterpolableValue,
value,

Powered by Google App Engine
This is Rietveld 408576698