Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: net/nqe/network_qualities_prefs_manager.cc

Issue 2487883002: NQE: Use cached estimates (Closed)
Patch Set: ps Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_qualities_prefs_manager.cc
diff --git a/net/nqe/network_qualities_prefs_manager.cc b/net/nqe/network_qualities_prefs_manager.cc
index 64c9f5c44513c87e7f019e833c406d251c5cf991..ba3036b64f401ad2571be5c0e63431381e50ffbf 100644
--- a/net/nqe/network_qualities_prefs_manager.cc
+++ b/net/nqe/network_qualities_prefs_manager.cc
@@ -56,7 +56,7 @@ NetworkQualitiesPrefsManager::NetworkQualitiesPrefsManager(
std::unique_ptr<PrefDelegate> pref_delegate)
: pref_delegate_(std::move(pref_delegate)),
pref_task_runner_(base::ThreadTaskRunnerHandle::Get()),
- prefs_(pref_delegate_->GetDictionaryValue().CreateDeepCopy()),
+ prefs_(pref_delegate_->GetDictionaryValue()),
network_quality_estimator_(nullptr),
read_prefs_startup_(ConvertDictionaryValueToMap(prefs_.get())),
pref_weak_ptr_factory_(this) {
@@ -153,7 +153,7 @@ void NetworkQualitiesPrefsManager::OnChangeInCachedNetworkQualityOnPrefThread(
ParsedPrefs NetworkQualitiesPrefsManager::ForceReadPrefsForTesting() const {
DCHECK(pref_task_runner_->RunsTasksOnCurrentThread());
std::unique_ptr<base::DictionaryValue> value(
- pref_delegate_->GetDictionaryValue().CreateDeepCopy());
+ pref_delegate_->GetDictionaryValue());
return ConvertDictionaryValueToMap(value.get());
}

Powered by Google App Engine
This is Rietveld 408576698