Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: net/nqe/network_qualities_prefs_manager.h

Issue 2487883002: NQE: Use cached estimates (Closed)
Patch Set: ps Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_qualities_prefs_manager.h
diff --git a/net/nqe/network_qualities_prefs_manager.h b/net/nqe/network_qualities_prefs_manager.h
index 591510968665cb4a7049a51a9e3957d4a5a0ada4..102b88ed31a4fbdef7cd2d4748856ee8916d531b 100644
--- a/net/nqe/network_qualities_prefs_manager.h
+++ b/net/nqe/network_qualities_prefs_manager.h
@@ -55,7 +55,7 @@ class NET_EXPORT NetworkQualitiesPrefsManager
virtual void SetDictionaryValue(const base::DictionaryValue& value) = 0;
// Returns the peristent prefs.
RyanSturm 2016/12/13 21:08:35 nit: s/the persistent/a copy of the persistent/
tbansal1 2016/12/14 01:37:37 Done.
- virtual const base::DictionaryValue& GetDictionaryValue() = 0;
+ virtual std::unique_ptr<base::DictionaryValue> GetDictionaryValue() = 0;
};
// Creates an instance of the NetworkQualitiesPrefsManager. Ownership of

Powered by Google App Engine
This is Rietveld 408576698