[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

Fixing regression caused by https://codereview.chromium.org/2447523002.

The issue is InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted()
is trying to kick off an animation on an InkDropRipple instance that is already
being destroyed. This is due to a
LayerAnimationObserver::OnLayerAnimationStarted() event being raised within a
LayerAnimator::AbortAllAnimations() call. This change is a short term fix to
prevent crashes. We will need to investigate how/if the animation framework
should be supporting such a use case.

TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown
BUG=663335
Committed: https://crrev.com/71e742597731adbca120dd6961dc8c5fe66bc1f0
Cr-Commit-Position: refs/heads/master@{#430677}

[bruthig, 2016-11-08 18:00:18]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 18:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 18:49:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 18:49:32]

Dry run: This issue passed the CQ dry run.

[bruthig, 2016-11-08 18:54:51]

Description was changed from

==========
[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

Fixing regression caused by https://codereview.chromium.org/2447523002.

TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown
BUG=663335
==========

to

==========
[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

Fixing regression caused by https://codereview.chromium.org/2447523002.

The issue is InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted()
is trying to kick off an animation on an InkDropRipple instance that is already
being destroyed. This is due to a
LayerAnimationObserver::OnLayerAnimationStarted() event being raised within a
LayerAnimator::AbortAllAnimations() call. This change is a short term fix to
prevent crashes. We will need to investigate how/if the animation framework
should be supporting such a use case.

TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown
BUG=663335
==========

[bruthig, 2016-11-08 18:55:18]

bruthig@chromium.org changed reviewers:
+ tdanderson@chromium.org

[bruthig, 2016-11-08 18:55:18]

tdanderson@, can you PTAL?

[tdanderson, 2016-11-08 18:59:07]

On 2016/11/08 18:55:18, bruthig wrote:
> tdanderson@, can you PTAL?

LGTM

[tdanderson, 2016-11-08 18:59:14]

https://codereview.chromium.org/2487723003/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_impl_unittest.cc (right):

https://codereview.chromium.org/2487723003/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_impl_unittest.cc:482: // of the InkDropRipple. See
https://crbug.com/663335.
Thanks for adding a test

[bruthig, 2016-11-08 19:00:31]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-11-08 19:00:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 19:07:58]

Description was changed from

==========
[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

Fixing regression caused by https://codereview.chromium.org/2447523002.

The issue is InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted()
is trying to kick off an animation on an InkDropRipple instance that is already
being destroyed. This is due to a
LayerAnimationObserver::OnLayerAnimationStarted() event being raised within a
LayerAnimator::AbortAllAnimations() call. This change is a short term fix to
prevent crashes. We will need to investigate how/if the animation framework
should be supporting such a use case.

TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown
BUG=663335
==========

to

==========
[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

Fixing regression caused by https://codereview.chromium.org/2447523002.

The issue is InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted()
is trying to kick off an animation on an InkDropRipple instance that is already
being destroyed. This is due to a
LayerAnimationObserver::OnLayerAnimationStarted() event being raised within a
LayerAnimator::AbortAllAnimations() call. This change is a short term fix to
prevent crashes. We will need to investigate how/if the animation framework
should be supporting such a use case.

TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown
BUG=663335
==========

[commit-bot: I haz the power, 2016-11-08 19:07:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-08 19:39:34]

Description was changed from

==========
[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

Fixing regression caused by https://codereview.chromium.org/2447523002.

The issue is InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted()
is trying to kick off an animation on an InkDropRipple instance that is already
being destroyed. This is due to a
LayerAnimationObserver::OnLayerAnimationStarted() event being raised within a
LayerAnimator::AbortAllAnimations() call. This change is a short term fix to
prevent crashes. We will need to investigate how/if the animation framework
should be supporting such a use case.

TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown
BUG=663335
==========

to

==========
[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

Fixing regression caused by https://codereview.chromium.org/2447523002.

The issue is InkDropImpl::HideHighlightOnRippleHiddenState::AnimationStarted()
is trying to kick off an animation on an InkDropRipple instance that is already
being destroyed. This is due to a
LayerAnimationObserver::OnLayerAnimationStarted() event being raised within a
LayerAnimator::AbortAllAnimations() call. This change is a short term fix to
prevent crashes. We will need to investigate how/if the animation framework
should be supporting such a use case.

TEST=InkDropImplHideAutoHighlightTest.NoCrashDuringRippleTearDown
BUG=663335

Committed: https://crrev.com/71e742597731adbca120dd6961dc8c5fe66bc1f0
Cr-Commit-Position: refs/heads/master@{#430677}
==========

[commit-bot: I haz the power, 2016-11-08 19:39:36]

Patchset 1 (id:??) landed as
https://crrev.com/71e742597731adbca120dd6961dc8c5fe66bc1f0
Cr-Commit-Position: refs/heads/master@{#430677}