[ash-md] Fixed crash when DEACTIVATING a focused ink drop button.

ui/views/animation/ink_drop_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "ui/views/animation/ink_drop_impl.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 460 matching lines @@
   ink_drop()->SetHovered(false);
   ink_drop()->SetFocused(false);
 
   ink_drop()->SetHovered(true);
   ink_drop()->SetFocused(true);
 
   EXPECT_FALSE(test_api()->IsHighlightFadingInOrVisible());
   EXPECT_TRUE(test_api()->ShouldHighlight());
 }
 
+// Verifies there is no crash when animations are started during the destruction
+// of the InkDropRipple. See https://crbug.com/663335.

[tdanderson, 2016/11/08 18:59:14]

Thanks for adding a test

+TEST_P(InkDropImplHideAutoHighlightTest, NoCrashDuringRippleTearDown) {
+  ink_drop()->SetShowHighlightOnFocus(true);
+  ink_drop()->SetFocused(true);
+  ink_drop()->AnimateToState(InkDropState::ACTIVATED);
+  ink_drop()->AnimateToState(InkDropState::DEACTIVATED);
+  ink_drop()->AnimateToState(InkDropState::DEACTIVATED);
+  DestroyInkDrop();
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 //
 // InkDropImpl::AutoHighlightMode::SHOW_ON_RIPPLE specific tests
 //
 
 typedef InkDropImplAutoHighlightTest InkDropImplShowAutoHighlightTest;
 // Note: First argument is optional and intentionally left blank.
 // (it's a prefix for the generated test cases)
 INSTANTIATE_TEST_CASE_P(
     ,
@@ skipping 34 matching lines @@
   EXPECT_TRUE(test_api()->IsHighlightFadingInOrVisible());
 
   ink_drop()->SetHovered(false);
   ink_drop()->SetFocused(false);
 
   EXPECT_TRUE(test_api()->IsHighlightFadingInOrVisible());
   EXPECT_FALSE(test_api()->ShouldHighlight());
 }
 
 }  // namespace views