Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2487693002: Add mobile-friendly menu (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add mobile-friendly menu This allows users to login on mobile instead of it being hidden offscreen BUG=655695 Committed: https://github.com/luci/luci-py/commit/c8f977e678566bbd40d15c2ff2763c4b86f277a3

Patch Set 1 #

Patch Set 2 : fix z-index and oldui link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -11 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/swarming-app.html View 1 5 chunks +50 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
kjlubick
https://screenshot.googleplex.com/xVRjZSrgztR https://screenshot.googleplex.com/zEda4v2ESGC https://screenshot.googleplex.com/F7u7B0hcsFA See live at https://2466-e3fbb1f-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com
4 years, 1 month ago (2016-11-08 14:38:29 UTC) #2
stephana-chromium
On 2016/11/08 14:38:29, kjlubick wrote: > https://screenshot.googleplex.com/xVRjZSrgztR > https://screenshot.googleplex.com/zEda4v2ESGC > https://screenshot.googleplex.com/F7u7B0hcsFA > > See live ...
4 years, 1 month ago (2016-11-08 14:47:52 UTC) #4
kjlubick
On 2016/11/08 at 14:47:52, stephana wrote: > On 2016/11/08 14:38:29, kjlubick wrote: > > https://screenshot.googleplex.com/xVRjZSrgztR ...
4 years, 1 month ago (2016-11-08 15:59:51 UTC) #5
KevinL
lgtm
4 years, 1 month ago (2016-11-08 15:59:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487693002/20001
4 years, 1 month ago (2016-11-08 16:00:00 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 16:03:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/c8f977e678566bbd40d15c2ff2763c4b86f277a3

Powered by Google App Engine
This is Rietveld 408576698