[debugger] Basic scope functionality and exception events in wrapper

[debugger] Basic scope functionality and exception events in wrapper

BUG=v8:5530
Committed: https://crrev.com/0cb3897179cd736fdfc9ecb7f2af88fd61ff572f
Cr-Commit-Position: refs/heads/master@{#40840}

[jgruber, 2016-11-08 13:23:11]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 13:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-11-08 13:25:41]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-11-08 13:25:42]

Note that this also adds logic for 'Files:' specifications to testcfg.py. Very
similar to mjsunit/ except for the ordering of the files; in this case, we need
test-api.js to be before the specified files, which in turn need to be before
the actual test case.

[Yang, 2016-11-08 13:37:27]

On 2016/11/08 13:25:42, jgruber wrote:
> Note that this also adds logic for 'Files:' specifications to testcfg.py. Very
> similar to mjsunit/ except for the ordering of the files; in this case, we
need
> test-api.js to be before the specified files, which in turn need to be before
> the actual test case.

lgtm!

[Yang, 2016-11-08 13:37:33]

https://codereview.chromium.org/2487673002/diff/1/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2487673002/diff/1/test/debugger/test-api.js#n...
test/debugger/test-api.js:248: return { scopeType : () =>
this.execStateScopeType(scope.type),
Just curious: do we need to specify 'this' explicitly here?

https://codereview.chromium.org/2487673002/diff/1/test/debugger/test-api.js#n...
test/debugger/test-api.js:264: , allScopes : () =>
frame.scopeChain.map(this.execStateScope.bind(this))
formatting (comma, and 80-char limit) :)

[commit-bot: I haz the power, 2016-11-08 13:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 13:47:30]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-08 13:58:35]

https://codereview.chromium.org/2487673002/diff/1/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2487673002/diff/1/test/debugger/test-api.js#n...
test/debugger/test-api.js:248: return { scopeType : () =>
this.execStateScopeType(scope.type),
On 2016/11/08 13:37:33, Yang wrote:
> Just curious: do we need to specify 'this' explicitly here?

We do :/

$ out/debug/d8 <<< 'class Foo { x() { print("Hello World"); } y() { x(); } };
new Foo().y();'
V8 version 5.6.0 (candidate)
d8> (d8):1: ReferenceError: x is not defined
class Foo { x() { print("Hello World"); } y() { x(); } }; new Foo().y();
                                                ^
ReferenceError: x is not defined
    at Foo.y ((d8):1:49)
    at (d8):1:69

https://codereview.chromium.org/2487673002/diff/1/test/debugger/test-api.js#n...
test/debugger/test-api.js:264: , allScopes : () =>
frame.scopeChain.map(this.execStateScope.bind(this))
On 2016/11/08 13:37:33, Yang wrote:
> formatting (comma, and 80-char limit) :)

Done, ty.

[jgruber, 2016-11-08 13:59:40]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 13:59:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:15:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 14:15:53]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15818)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12113)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[jgruber, 2016-11-08 14:21:02]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:21:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 14:51:05]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-08 14:51:34]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-11-08 14:51:35]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2487673002/#ps30001
(title: "Formatting")

[commit-bot: I haz the power, 2016-11-08 14:51:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:53:56]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-11-17 22:26:24]

Description was changed from

==========
[debugger] Basic scope functionality and exception events in wrapper

BUG=v8:5530
==========

to

==========
[debugger] Basic scope functionality and exception events in wrapper

BUG=v8:5530

Committed: https://crrev.com/0cb3897179cd736fdfc9ecb7f2af88fd61ff572f
Cr-Commit-Position: refs/heads/master@{#40840}
==========

[commit-bot: I haz the power, 2016-11-17 22:26:26]

Patchset 3 (id:??) landed as
https://crrev.com/0cb3897179cd736fdfc9ecb7f2af88fd61ff572f
Cr-Commit-Position: refs/heads/master@{#40840}