Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2482903002: [debugger] Stepping and break-related functions in wrapper (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Stepping and break-related functions in wrapper This adds clearStepping plus the family of {set,clear}BreakOn{,Uncaught}Exception functions. BUG=v8:5530 Committed: https://crrev.com/4d6ff7dfaaeb46ca48c0964a4b88f35f69bfb015 Cr-Commit-Position: refs/heads/master@{#40834}

Patch Set 1 #

Patch Set 2 : [debugger] Stepping and break-related functions in wrapper #

Patch Set 3 : Disable printing of protocol messages #

Patch Set 4 : Fix typo and remove failing test #

Patch Set 5 : Correctly revert changes to testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -239 lines) Patch
A + test/debugger/debug/debug-constructor.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es6/debug-promises/reject-after-resolve.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/harmony/debug-async-function-async-task-event.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-401915.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/test-api.js View 1 2 3 3 chunks +39 lines, -2 lines 0 comments Download
D test/mjsunit/debug-constructor.js View 1 chunk +0 lines, -78 lines 0 comments Download
D test/mjsunit/es6/debug-promises/reject-after-resolve.js View 1 chunk +0 lines, -37 lines 0 comments Download
D test/mjsunit/harmony/debug-async-function-async-task-event.js View 1 chunk +0 lines, -97 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-401915.js View 1 chunk +0 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (22 generated)
jgruber
4 years, 1 month ago (2016-11-08 11:58:28 UTC) #10
Yang
On 2016/11/08 11:58:28, jgruber wrote: lgtm. nice!
4 years, 1 month ago (2016-11-08 11:59:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2482903002/80001
4 years, 1 month ago (2016-11-08 13:52:00 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-08 13:54:02 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:10 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4d6ff7dfaaeb46ca48c0964a4b88f35f69bfb015
Cr-Commit-Position: refs/heads/master@{#40834}

Powered by Google App Engine
This is Rietveld 408576698