Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: components/search_engines/default_search_manager_unittest.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)
Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_manager_unittest.cc
diff --git a/components/search_engines/default_search_manager_unittest.cc b/components/search_engines/default_search_manager_unittest.cc
index a8df14e94ba0a83dcdcaa0d77edaa7862fe38952..49aa45c4a8ad6f7fd1c4aa2964f62035423c223d 100644
--- a/components/search_engines/default_search_manager_unittest.cc
+++ b/components/search_engines/default_search_manager_unittest.cc
@@ -41,7 +41,6 @@ void ExpectSimilar(const TemplateURLData* expected,
EXPECT_EQ(expected->suggestions_url, actual->suggestions_url);
EXPECT_EQ(expected->favicon_url, actual->favicon_url);
EXPECT_EQ(expected->alternate_urls, actual->alternate_urls);
- EXPECT_EQ(expected->show_in_default_list, actual->show_in_default_list);
EXPECT_EQ(expected->safe_for_autoreplace, actual->safe_for_autoreplace);
EXPECT_EQ(expected->input_encodings, actual->input_encodings);
EXPECT_EQ(expected->search_terms_replacement_key,
@@ -134,7 +133,6 @@ std::unique_ptr<TemplateURLData> GenerateDummyTemplateURLData(
std::string("http://").append(type).append("foo/alt"));
data->favicon_url = GURL("http://icon1");
data->safe_for_autoreplace = true;
- data->show_in_default_list = true;
data->input_encodings = base::SplitString(
"UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
data->date_created = base::Time();
@@ -176,7 +174,6 @@ TEST_F(DefaultSearchManagerTest, ReadAndWritePref) {
data.alternate_urls.push_back("http://foo1/alt");
data.favicon_url = GURL("http://icon1");
data.safe_for_autoreplace = true;
- data.show_in_default_list = true;
data.input_encodings = base::SplitString(
"UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
data.date_created = base::Time();
« no previous file with comments | « components/search_engines/default_search_manager.cc ('k') | components/search_engines/default_search_pref_migration.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698