Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: chrome/browser/ui/search_engines/template_url_table_model.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search_engines/template_url_table_model.cc
diff --git a/chrome/browser/ui/search_engines/template_url_table_model.cc b/chrome/browser/ui/search_engines/template_url_table_model.cc
index bbfb283c9d0a946e812b563c12e54bb59952919b..7ef83d07fcd5de60e7b8aaa1134ec9dbd817a016 100644
--- a/chrome/browser/ui/search_engines/template_url_table_model.cc
+++ b/chrome/browser/ui/search_engines/template_url_table_model.cc
@@ -143,9 +143,7 @@ void TemplateURLTableModel::Reload() {
extension_entries;
// Keywords that can be made the default first.
for (auto* template_url : urls) {
- // NOTE: we don't use ShowInDefaultList here to avoid items bouncing around
- // the lists while editing.
- if (template_url->show_in_default_list())
+ if (template_url_service_->ShowInDefaultList(template_url))
Peter Kasting 2016/11/10 06:41:06 Nit: While here: This code is out of compliance wi
ltian 2016/11/11 03:52:13 Done.
default_entries.push_back(
base::MakeUnique<ModelEntry>(this, template_url));
else if (template_url->type() == TemplateURL::OMNIBOX_API_EXTENSION)

Powered by Google App Engine
This is Rietveld 408576698