Move SerializedScriptValue wire format version to public header

Move SerializedScriptValue wire format version to public header

R=jamesr@chromium.org,haraken@chromium.org
BUG=299125
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158478

[jsbell, 2013-09-27 00:13:33]

jamesr@, haraken@ - please take a look.

Bug has the rationale, corresponding Chromium CL is
https://codereview.chromium.org/24904002

[abarth-chromium, 2013-09-27 00:16:41]

I would put this value in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
and then COMPILE_ASSERT that the value matches the internal value.

[michaeln, 2013-09-27 00:52:27]

On 2013/09/27 00:16:41, abarth wrote:
> I would put this value in
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> and then COMPILE_ASSERT that the value matches the internal value.

The thing is we want to #include this header in the browser process too.
WebSerializedScriptValue has too much code behind it, we just want the constant
value and zero risk of linking code or hints or temptations to do so.

[abarth-chromium, 2013-09-27 00:57:19]

On 2013/09/27 00:52:27, michaeln wrote:
> The thing is we want to #include this header in the browser process too.
> WebSerializedScriptValue has too much code behind it, we just want the
constant
> value and zero risk of linking code or hints or temptations to do so.

Ah, ok.  Maybe public/web/WebSerializedScriptValueVersion.h with a
COMPILE_ASSERT?

I'd prefer to put the header in the public/web directory because public/platform
shouldn't know about things like script values.

[jsbell, 2013-09-27 16:47:09]

On 2013/09/27 00:57:19, abarth wrote:
> On 2013/09/27 00:52:27, michaeln wrote:
> > The thing is we want to #include this header in the browser process too.
> > WebSerializedScriptValue has too much code behind it, we just want the
> constant
> > value and zero risk of linking code or hints or temptations to do so.
> 
> Ah, ok.  Maybe public/web/WebSerializedScriptValueVersion.h with a
> COMPILE_ASSERT?
> 
> I'd prefer to put the header in the public/web directory because
public/platform
> shouldn't know about things like script values.

Thanks for the feedback - done and done and done.

* I put the COMPILE_ASSERT in AssertMatchingEnums along with similar checks. It
could also live in the Source/web/WebSerializedScriptValue.cpp
* I changed to bindings/v8/SerializedScriptValue to expose the version as a
constant rather than through a method.
* I dropped the "k" prefix from the constant since that seemed to be more
common, but we appear to be inconsistent in consts in the public headers.

[abarth-chromium, 2013-09-27 16:56:47]

LGTM

I'd probably add the k through.  I'm not sure we're super consistent about it.

[commit-bot: I haz the power, 2013-09-27 19:25:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/24876004/11001

[commit-bot: I haz the power, 2013-09-27 23:42:02]

Change committed as 158478