Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 24904002: IndexedDB: Consume SSV wire format version from Blink public headers (Closed)

Created:
7 years, 2 months ago by jsbell
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

IndexedDB: Consume SSV wire format version from Blink public headers IndexedDB writes the "wire format version" for serialized data into the database metadata to detect the case where a user reverts to an older version of the browser and data "from the future" will not be understood. Detecting this early lets us fail the open, rather than later mysterious inconsistency errors. When the back-end was in Blink the value could be grabbed directly from the SerializedScriptValue class. Now it is exposed via headers. BUG=299125 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226338

Patch Set 1 #

Patch Set 2 : Redux #

Patch Set 3 : Added the k back in #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
michaeln
however the webkit api shakes out... lgtm
7 years, 2 months ago (2013-09-27 00:58:37 UTC) #1
jsbell
sky@ - OWNERS review for content/browser/DEPS change?
7 years, 2 months ago (2013-09-30 15:50:11 UTC) #2
sky
LGTM
7 years, 2 months ago (2013-09-30 16:06:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/24904002/7001
7 years, 2 months ago (2013-09-30 16:23:34 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=28139
7 years, 2 months ago (2013-10-01 01:17:21 UTC) #5
jsbell
Whoops - Chromium presubmit says this CL needs an LGTM from a WebKit/public/web OWNERS member ...
7 years, 2 months ago (2013-10-01 16:05:26 UTC) #6
abarth-chromium
This one is for jamesr, but I think its ok.
7 years, 2 months ago (2013-10-01 19:41:20 UTC) #7
jamesr
lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
7 years, 2 months ago (2013-10-01 19:44:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/24904002/7001
7 years, 2 months ago (2013-10-01 20:08:08 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 23:22:19 UTC) #10
Message was sent while issue was closed.
Change committed as 226338

Powered by Google App Engine
This is Rietveld 408576698