Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2487583002: Convert generic method errors to hints (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, Leaf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add missed code #

Total comments: 8

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -116 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/error/hint_codes.dart View 10 chunks +157 lines, -107 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 2 1 chunk +11 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
Sorry about the churn in hint_codes; it's due to re-ordering. Happy to revert all but ...
4 years, 1 month ago (2016-11-08 01:10:40 UTC) #2
Jennifer Messerly
LGTM w/ fix to preserve strong mode behavior. https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/lib/src/generated/element_resolver.dart File pkg/analyzer/lib/src/generated/element_resolver.dart (right): https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/lib/src/generated/element_resolver.dart#newcode1581 pkg/analyzer/lib/src/generated/element_resolver.dart:1581: HintCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_METHOD, ...
4 years, 1 month ago (2016-11-08 01:21:57 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/lib/src/generated/element_resolver.dart File pkg/analyzer/lib/src/generated/element_resolver.dart (right): https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/lib/src/generated/element_resolver.dart#newcode1581 pkg/analyzer/lib/src/generated/element_resolver.dart:1581: HintCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_METHOD, On 2016/11/08 01:21:57, Jennifer Messerly wrote: > This ...
4 years, 1 month ago (2016-11-08 01:22:30 UTC) #4
Brian Wilkerson
ptal https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/lib/src/generated/element_resolver.dart File pkg/analyzer/lib/src/generated/element_resolver.dart (right): https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/lib/src/generated/element_resolver.dart#newcode1581 pkg/analyzer/lib/src/generated/element_resolver.dart:1581: HintCode.WRONG_NUMBER_OF_TYPE_ARGUMENTS_METHOD, Done https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/test/generated/static_type_warning_code_test.dart File pkg/analyzer/test/generated/static_type_warning_code_test.dart (right): https://codereview.chromium.org/2487583002/diff/20001/pkg/analyzer/test/generated/static_type_warning_code_test.dart#newcode2433 pkg/analyzer/test/generated/static_type_warning_code_test.dart:2433: ...
4 years, 1 month ago (2016-11-08 15:39:07 UTC) #5
Jennifer Messerly
lgtm!
4 years, 1 month ago (2016-11-08 18:46:34 UTC) #6
Brian Wilkerson
4 years, 1 month ago (2016-11-08 19:06:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
562c2be1849add4f00a6c0ea952adb9c993287f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698