Convert generic method errors to hints

pkg/analyzer/lib/src/generated/error_verifier.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.error_verifier;
 
 import 'dart:collection';
 import "dart:math" as math;
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 1736 matching lines @@
     // an error message once it's ready to "return false".
     if (!derivedFT.typeFormals.isEmpty) {
       if (baseFT.typeFormals.isEmpty) {
         derivedFT = _typeSystem.instantiateToBounds(derivedFT);
       } else {
         List<TypeParameterElement> params1 = derivedFT.typeFormals;
         List<TypeParameterElement> params2 = baseFT.typeFormals;
         int count = params1.length;
         if (params2.length != count) {
           _errorReporter.reportErrorForNode(
-              StaticWarningCode.INVALID_METHOD_OVERRIDE_TYPE_PARAMETERS,
+              HintCode.INVALID_METHOD_OVERRIDE_TYPE_PARAMETERS,

[Jennifer Messerly, 2016/11/08 01:21:57]

I think this one is okay though, because we don't go down this code path in
strong mode.

               errorNameTarget, [
             count,
             params2.length,
             baseElement.enclosingElement.displayName
           ]);
           return true;
         }
         // We build up a substitution matching up the type parameters
         // from the two types, {variablesFresh/variables1} and
         // {variablesFresh/variables2}
@@ skipping 13 matching lines @@
           variables1.add(variable1);
           variables2.add(variable2);
           variablesFresh.add(variableFresh);
           DartType bound1 = p1.bound ?? DynamicTypeImpl.instance;
           DartType bound2 = p2.bound ?? DynamicTypeImpl.instance;
           bound1 = bound1.substitute2(variablesFresh, variables1);
           bound2 = bound2.substitute2(variablesFresh, variables2);
           pFresh.bound = bound2;
           if (!_typeSystem.isSubtypeOf(bound2, bound1)) {
             _errorReporter.reportErrorForNode(
-                StaticWarningCode.INVALID_METHOD_OVERRIDE_TYPE_PARAMETER_BOUND,
+                HintCode.INVALID_METHOD_OVERRIDE_TYPE_PARAMETER_BOUND,
                 errorNameTarget, [
               p1.displayName,
               p1.bound,
               p2.displayName,
               p2.bound,
               baseElement.enclosingElement.displayName
             ]);
             return true;
           }
         }
@@ skipping 5128 matching lines @@
 class _InvocationCollector extends RecursiveAstVisitor {
   final List<String> superCalls = <String>[];
 
   @override
   visitMethodInvocation(MethodInvocation node) {
     if (node.target is SuperExpression) {
       superCalls.add(node.methodName.name);
     }
   }
 }