Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun.

chrome/browser/ui/startup/startup_tab_provider.h

Index: chrome/browser/ui/startup/startup_tab_provider.h
diff --git a/chrome/browser/ui/startup/startup_tab_provider.h b/chrome/browser/ui/startup/startup_tab_provider.h
index 0c24d83a52b418501e2f13281ce9eca7e8ec82a5..c2c8eb23ca5e1d7a0a3d00fd7fa6a7e318dc42e6 100644
--- a/chrome/browser/ui/startup/startup_tab_provider.h
+++ b/chrome/browser/ui/startup/startup_tab_provider.h
@@ -22,7 +22,7 @@ class StartupTabProvider {
  public:
   // Gathers relevant system state and returns any tabs which should be
   // shown according to onboarding/first run policy.
-  virtual StartupTabs GetOnboardingTabs() const = 0;
+  virtual StartupTabs GetOnboardingTabs(Profile* profile) const = 0;
 
   // Gathers URLs from a Master Preferences file indicating first run logic
   // specific to this distribution. Transforms any such URLs per policy and
@@ -60,7 +60,11 @@ class StartupTabProviderImpl : public StartupTabProvider {
 
   // Determines which tabs which should be shown according to onboarding/first
   // run policy.

[Peter Kasting, 2016/11/10 05:26:43]

Nit: Improve documentation of parameters; in particular,
|created_after_welcome_ui| isn't obvious.

[tmartino, 2016/11/15 00:16:30]

This will be obsolete pending changes from the other comment; see the question
there.

-  static StartupTabs CheckStandardOnboardingTabPolicy(bool is_first_run);
+  static StartupTabs CheckStandardOnboardingTabPolicy(
+      bool is_first_run,
+      bool has_seen_welcome,
+      bool is_signed_in,
+      bool created_after_welcome_ui);
 
   // Processes first run URLs specified in Master Preferences file, replacing
   // any "magic word" URL hosts with appropriate URLs.
@@ -88,14 +92,14 @@ class StartupTabProviderImpl : public StartupTabProvider {
   static StartupTabs CheckNewTabPageTabPolicy(const SessionStartupPref& pref);
 
   // Gets the URL for the "Welcome to Chrome" page.

[Peter Kasting, 2016/11/10 05:26:43]

Nit: Update to document the meaning of the parameter.

[tmartino, 2016/11/15 00:16:30]

Done.

-  static GURL GetWelcomePageUrl();
+  static GURL GetWelcomePageUrl(bool use_later_run_variant);
 
   // Gets the URL for the page which offers to reset the user's profile
   // settings.
   static GURL GetTriggeredResetSettingsUrl();
 
   // StartupTabProvider:
-  StartupTabs GetOnboardingTabs() const override;
+  StartupTabs GetOnboardingTabs(Profile* profile) const override;
   StartupTabs GetDistributionFirstRunTabs(
       StartupBrowserCreator* browser_creator) const override;
   StartupTabs GetResetTriggerTabs(Profile* profile) const override;