Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun.

chrome/browser/ui/startup/startup_tab_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_PROVIDER_H_
 #define CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_PROVIDER_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/browser/ui/startup/startup_tab.h"
 #include "url/gurl.h"
 
 // Provides the sets of tabs to be shown at startup for given sets of policy.
 // For instance, this class answers the question, "which tabs, if any, need to
 // be shown for first run/onboarding?" Provided as a virtual interface to allow
 // faking in unit tests.
 class StartupTabProvider {
  public:
   // Gathers relevant system state and returns any tabs which should be
   // shown according to onboarding/first run policy.
-  virtual StartupTabs GetOnboardingTabs() const = 0;
+  virtual StartupTabs GetOnboardingTabs(Profile* profile) const = 0;
 
   // Gathers URLs from a Master Preferences file indicating first run logic
   // specific to this distribution. Transforms any such URLs per policy and
   // returns them. Also clears the value of first_run_urls_ in the provided
   // BrowserCreator.
   virtual StartupTabs GetDistributionFirstRunTabs(
       StartupBrowserCreator* browser_creator) const = 0;
 
   // Checks for the presence of a trigger indicating the need to offer a Profile
   // Reset on this profile. Returns any tabs which should be shown accordingly.
@@ skipping 16 matching lines @@
 
 class StartupTabProviderImpl : public StartupTabProvider {
  public:
   StartupTabProviderImpl() = default;
 
   // The static Check*TabPolicy methods below enforce the policies relevant to
   // the respective Get*Tabs methods, but do not gather or interact with any
   // system state relating to making those policy decisions.
 
   // Determines which tabs which should be shown according to onboarding/first
   // run policy.

[Peter Kasting, 2016/11/10 05:26:43]

Nit: Improve documentation of parameters; in particular,
|created_after_welcome_ui| isn't obvious.

[tmartino, 2016/11/15 00:16:30]

This will be obsolete pending changes from the other comment; see the question
there.

-  static StartupTabs CheckStandardOnboardingTabPolicy(bool is_first_run);
+  static StartupTabs CheckStandardOnboardingTabPolicy(
+      bool is_first_run,
+      bool has_seen_welcome,
+      bool is_signed_in,
+      bool created_after_welcome_ui);
 
   // Processes first run URLs specified in Master Preferences file, replacing
   // any "magic word" URL hosts with appropriate URLs.
   static StartupTabs CheckMasterPrefsTabPolicy(
       bool is_first_run,
       const std::vector<GURL>& first_run_tabs);
 
   // Determines which tabs should be shown as a result of the presence/absence
   // of a Reset Trigger on this profile.
   static StartupTabs CheckResetTriggerTabPolicy(bool profile_has_trigger);
 
   // Determines whether the startup preference requires the contents of
   // |pinned_tabs| to be shown. This is needed to avoid duplicates, as the
   // session restore logic will also resurface pinned tabs on its own.
   static StartupTabs CheckPinnedTabPolicy(const SessionStartupPref& pref,
                                           const StartupTabs& pinned_tabs);
 
   // Determines whether preferences indicate that user-specified tabs should be
   // shown as the default new window content, and returns the specified tabs if
   // so.
   static StartupTabs CheckPreferencesTabPolicy(const SessionStartupPref& pref);
 
   // Determines whether startup preferences require the New Tab Page to be
   // explicitly specified. Session Restore does not expect the NTP to be passed.
   static StartupTabs CheckNewTabPageTabPolicy(const SessionStartupPref& pref);
 
   // Gets the URL for the "Welcome to Chrome" page.

[Peter Kasting, 2016/11/10 05:26:43]

Nit: Update to document the meaning of the parameter.

[tmartino, 2016/11/15 00:16:30]

Done.

-  static GURL GetWelcomePageUrl();
+  static GURL GetWelcomePageUrl(bool use_later_run_variant);
 
   // Gets the URL for the page which offers to reset the user's profile
   // settings.
   static GURL GetTriggeredResetSettingsUrl();
 
   // StartupTabProvider:
-  StartupTabs GetOnboardingTabs() const override;
+  StartupTabs GetOnboardingTabs(Profile* profile) const override;
   StartupTabs GetDistributionFirstRunTabs(
       StartupBrowserCreator* browser_creator) const override;
   StartupTabs GetResetTriggerTabs(Profile* profile) const override;
   StartupTabs GetPinnedTabs(const base::CommandLine& command_line,
                             Profile* profile) const override;
   StartupTabs GetPreferencesTabs(const base::CommandLine& command_line,
                                  Profile* profile) const override;
   StartupTabs GetNewTabPageTabs(const base::CommandLine& command_line,
                                 Profile* profile) const override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(StartupTabProviderImpl);
 };
 
 #endif  // CHROME_BROWSER_UI_STARTUP_STARTUP_TAB_PROVIDER_H_