chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 2487553002: Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 2487553002: Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun. (Closed)

Patch Set: Adding tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index 5c8ae2881898f1a981237b2dc8184a6e5eb154b4..bbc91a181abe8957edce8c2ecf29eb65265c58f2 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -695,7 +695,7 @@ StartupTabs StartupBrowserCreatorImpl::DetermineStartupTabs(

// Policies for onboarding (e.g., first run) may show promotional and

// introductory content depending on a number of system status factors,

// including OS and whether or not this is First Run.

- StartupTabs onboarding_tabs = provider.GetOnboardingTabs();

+ StartupTabs onboarding_tabs = provider.GetOnboardingTabs(profile_);

AppendTabs(onboarding_tabs, &tabs);

// If the user has set the preference indicating URLs to show on opening,