|
|
DescriptionFix links to issue tracker in extensions docs
R=michaelpg@chromium.org, pbakaus@chromium.org
Review-Url: https://codereview.chromium.org/2487493005
Cr-Commit-Position: refs/heads/master@{#441732}
Committed: https://chromium.googlesource.com/chromium/src/+/91ce10c665667d62c7f523334f8f127c51ffdef4
Patch Set 1 #
Total comments: 4
Patch Set 2 : Comments #Patch Set 3 : Comments #
Messages
Total messages: 22 (7 generated)
https://codereview.chromium.org/2487493005/diff/1/chrome/common/extensions/do... File chrome/common/extensions/docs/templates/articles/faq.html (right): https://codereview.chromium.org/2487493005/diff/1/chrome/common/extensions/do... chrome/common/extensions/docs/templates/articles/faq.html:9: <a href="http://bugs.chromium.org/chrome/webstore/faq">Chrome Web Store FAQ</a>, the broken link https://codereview.chromium.org/2487493005/diff/1/chrome/common/extensions/do... chrome/common/extensions/docs/templates/articles/faq.html:467: <a href="https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component%3DPlatform-Extensions+Type%3DFeature+shortcuts"> Platform>Extensions not Platform-Extensions
Back from a long break, ptal https://codereview.chromium.org/2487493005/diff/1/chrome/common/extensions/do... File chrome/common/extensions/docs/templates/articles/faq.html (right): https://codereview.chromium.org/2487493005/diff/1/chrome/common/extensions/do... chrome/common/extensions/docs/templates/articles/faq.html:9: <a href="http://bugs.chromium.org/chrome/webstore/faq">Chrome Web Store FAQ</a>, the On 2016/11/14 at 20:36:07, michaelpg wrote: > broken link The old one was too :( Updated to my best guess https://codereview.chromium.org/2487493005/diff/1/chrome/common/extensions/do... chrome/common/extensions/docs/templates/articles/faq.html:467: <a href="https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component%3DPlatform-Extensions+Type%3DFeature+shortcuts"> On 2016/11/14 at 20:36:07, michaelpg wrote: > Platform>Extensions not Platform-Extensions Whoops, missed that one. Done.
lgtm
The CQ bit was checked by agable@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
pbakaus, ping for OWNERS
On 2017/01/05 at 19:03:04, agable wrote: > pbakaus, ping for OWNERS no idea why I'm an owner of this ticket :)
On 2017/01/05 at 19:08:36, pbakaus wrote: > On 2017/01/05 at 19:03:04, agable wrote: > > pbakaus, ping for OWNERS > > no idea why I'm an owner of this ticket :) Because you're an OWNER of the relevant files, and "git cl owners" picked you. I can pick someone else if necessary, but if you're not the right person to review this change, we should re-examine the OWNERS files and make them better.
On 2017/01/05 at 19:16:08, agable wrote: > On 2017/01/05 at 19:08:36, pbakaus wrote: > > On 2017/01/05 at 19:03:04, agable wrote: > > > pbakaus, ping for OWNERS > > > > no idea why I'm an owner of this ticket :) > > Because you're an OWNER of the relevant files, and "git cl owners" picked you. I can pick someone else if necessary, but if you're not the right person to review this change, we should re-examine the OWNERS files and make them better. Since I don't work or am familiar with Chrome extensions at all, I think re-examining the OWNERS file here would be great.
agable@chromium.org changed reviewers: - pbakaus@chromium.org
-pbakaus, +rockot for OWNERS review
agable@chromium.org changed reviewers: + rockot@chromium.org
(actually +rockot this time)
lgtm
The CQ bit was checked by agable@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483644555554640, "parent_rev": "7a89d1515e7c5e0779d22c07e9f80f6fe9f7c7ae", "commit_rev": "91ce10c665667d62c7f523334f8f127c51ffdef4"}
Message was sent while issue was closed.
Description was changed from ========== Fix links to issue tracker in extensions docs R=michaelpg@chromium.org, pbakaus@chromium.org ========== to ========== Fix links to issue tracker in extensions docs R=michaelpg@chromium.org, pbakaus@chromium.org Review-Url: https://codereview.chromium.org/2487493005 Cr-Commit-Position: refs/heads/master@{#441732} Committed: https://chromium.googlesource.com/chromium/src/+/91ce10c665667d62c7f523334f8f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/91ce10c665667d62c7f523334f8f... |