src/compiler/ast-graph-builder.cc - Issue 2487483004: Only treat possible eval calls going through 'with' as special.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 2487483004: Only treat possible eval calls going through 'with' as special. (Closed)

Patch Set: Fix AstGraphBuilder Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index 973104b2a907219a9085011d249c4e75bbbd0495..7939dcd1274bf0d748057acb71d567fd826628f1 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -2389,6 +2389,7 @@ void AstGraphBuilder::VisitCall(Call* expr) {

case Call::SUPER_CALL:

return VisitCallSuper(expr);

case Call::POSSIBLY_EVAL_CALL:

+ case Call::POSSIBLY_EVAL_THROUGH_WITH_CALL:

possibly_eval = true;

if (callee->AsVariableProxy()->var()->IsLookupSlot()) {

Variable* variable = callee->AsVariableProxy()->var();