src/ast/ast.cc - Issue 2487483004: Only treat possible eval calls going through 'with' as special.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast.cc

Issue 2487483004: Only treat possible eval calls going through 'with' as special. (Closed)

Patch Set: Fix AstGraphBuilder Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast.cc

diff --git a/src/ast/ast.cc b/src/ast/ast.cc

index e5eb5e55fa0faff5c459600cd176addcd1daddd6..0d937d70dd62dfe1bab61e56ab6803874dea4318 100644

--- a/src/ast/ast.cc

+++ b/src/ast/ast.cc

@@ -897,7 +897,8 @@ Call::CallType Call::GetCallType() const {

VariableProxy* proxy = expression()->AsVariableProxy();

if (proxy != NULL) {

if (is_possibly_eval()) {

- return POSSIBLY_EVAL_CALL;

+ return proxy->var()->mode() == DYNAMIC ? POSSIBLY_EVAL_THROUGH_WITH_CALL

+ : POSSIBLY_EVAL_CALL;

} else if (proxy->var()->IsUnallocated()) {

return GLOBAL_CALL;

} else if (proxy->var()->IsLookupSlot()) {