Raise timeouts on smooth scroll layout tests.

Raise timeouts on smooth scroll layout tests.

Speculative fix for flakiness in virtual/threaded.  Will update TestExpectations
if flakiness dashboard shows improvements.

BUG=587165, 593568, 624247, 636961
Committed: https://crrev.com/2fed361174d0f64bf1b2a3bf9171f639d477d2c7
Cr-Commit-Position: refs/heads/master@{#431145}

[skobes, 2016-11-07 20:46:16]

Description was changed from

==========
Raise timeouts on smooth scroll layout tests.

Speculative fix for flakiness in virtual/threaded.

BUG=587165,593568,624247,636961
==========

to

==========
Raise timeouts on smooth scroll layout tests.

Speculative fix for flakiness in virtual/threaded.  Will update TestExpectations
if flakiness dashboard shows improvements.

BUG=587165,593568,624247,636961
==========

[skobes, 2016-11-07 20:46:45]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[skobes, 2016-11-07 20:46:55]

skobes@chromium.org changed reviewers:
+ bokan@chromium.org, ymalik@chromium.org

[commit-bot: I haz the power, 2016-11-07 20:47:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:36:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[skobes, 2016-11-07 23:56:20]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 23:57:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 01:22:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[skobes, 2016-11-08 02:53:54]

Hold off on reviewing this until I fix the tests.

[skobes, 2016-11-09 20:48:56]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 20:49:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 21:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 21:41:40]

Dry run: This issue passed the CQ dry run.

[skobes, 2016-11-09 21:58:26]

Ok this is ready for review.

[ymalik, 2016-11-09 22:11:31]

lgtm

https://codereview.chromium.org/2487443002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll.html
(right):

https://codereview.chromium.org/2487443002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll.html:27:
internals.settings.setScrollAnimatorEnabled(true);
We can probably get rid of this from here and everywhere else while we're here
anyway.

https://codereview.chromium.org/2487443002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll-interrupted.html
(right):

https://codereview.chromium.org/2487443002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll-interrupted.html:12:
var defaultTimeoutForShouldBecome = 5000;
I suspect that the flakiness in this test may come from the fact that the scroll
animator is not in the correct state. But we can keep this since all smooth
scroll tests should probably have higher timeouts for debug builds.

[bokan, 2016-11-09 22:12:57]

lgtm

[skobes, 2016-11-10 01:09:21]

https://codereview.chromium.org/2487443002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll.html
(right):

https://codereview.chromium.org/2487443002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll.html:27:
internals.settings.setScrollAnimatorEnabled(true);
On 2016/11/09 22:11:30, ymalik wrote:
> We can probably get rid of this from here and everywhere else while we're here
> anyway.

I'll do this in a follow-up.

[skobes, 2016-11-10 01:09:25]

The CQ bit was checked by skobes@chromium.org

[skobes, 2016-11-10 01:09:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
ymalik@chromium.org
Link to the patchset: https://codereview.chromium.org/2487443002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-10 01:09:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 02:21:31]

Description was changed from

==========
Raise timeouts on smooth scroll layout tests.

Speculative fix for flakiness in virtual/threaded.  Will update TestExpectations
if flakiness dashboard shows improvements.

BUG=587165,593568,624247,636961
==========

to

==========
Raise timeouts on smooth scroll layout tests.

Speculative fix for flakiness in virtual/threaded.  Will update TestExpectations
if flakiness dashboard shows improvements.

BUG=587165,593568,624247,636961
==========

[commit-bot: I haz the power, 2016-11-10 02:21:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-10 02:41:51]

Description was changed from

==========
Raise timeouts on smooth scroll layout tests.

Speculative fix for flakiness in virtual/threaded.  Will update TestExpectations
if flakiness dashboard shows improvements.

BUG=587165,593568,624247,636961
==========

to

==========
Raise timeouts on smooth scroll layout tests.

Speculative fix for flakiness in virtual/threaded.  Will update TestExpectations
if flakiness dashboard shows improvements.

BUG=587165,593568,624247,636961

Committed: https://crrev.com/2fed361174d0f64bf1b2a3bf9171f639d477d2c7
Cr-Commit-Position: refs/heads/master@{#431145}
==========

[commit-bot: I haz the power, 2016-11-10 02:41:55]

Patchset 4 (id:??) landed as
https://crrev.com/2fed361174d0f64bf1b2a3bf9171f639d477d2c7
Cr-Commit-Position: refs/heads/master@{#431145}