third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll-interrupted.html - Issue 2487443002: Raise timeouts on smooth scroll layout tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll-interrupted.html

Issue 2487443002: Raise timeouts on smooth scroll layout tests. (Closed)

Patch Set: fix more tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll.html ('K') | « third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-added.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../../../resources/js-test.js"></script>	2 <script src="../../../../../resources/js-test.js"></script>

3 <style>	3 <style>

4 body {	4 body {

5 height: 2000px;	5 height: 2000px;

6 width: 2000px;	6 width: 2000px;

7 }	7 }

8 </style>	8 </style>

9	9

10 <script>	10 <script>

11 window.jsTestIsAsync = true;	11 window.jsTestIsAsync = true;

	12 var defaultTimeoutForShouldBecome = 5000;
	ymalik 2016/11/09 22:11:30 I suspect that the flakiness in this test may come I suspect that the flakiness in this test may come from the fact that the scroll animator is not in the correct state. But we can keep this since all smooth scroll tests should probably have higher timeouts for debug builds.
12	13

13 description("This test ensures that input driven user scrolls get cancelled\	14 description("This test ensures that input driven user scrolls get cancelled\

14 by non-input driven scrolls.");	15 by non-input driven scrolls.");

15	16

16 // From ScrollAnimatorCompositorCoordinator::RunState.	17 // From ScrollAnimatorCompositorCoordinator::RunState.

17 var IDLE = "Idle";	18 var IDLE = "Idle";

18 var RUNNING_ON_COMPOSITOR = "RunningOnCompositor";	19 var RUNNING_ON_COMPOSITOR = "RunningOnCompositor";

19 var WAITING_TO_CANCEL_ON_COMPOSITOR = "WaitingToCancelOnCompositor";	20 var WAITING_TO_CANCEL_ON_COMPOSITOR = "WaitingToCancelOnCompositor";

20 function isOrWillBeCancelled(node) {	21 function isOrWillBeCancelled(node) {

21 var state = internals.getScrollAnimationState(node);	22 var state = internals.getScrollAnimationState(node);

(...skipping 26 matching lines...) Expand all Loading...
48	49

49 document.scrollingElement.scrollTop = 0;	50 document.scrollingElement.scrollTop = 0;

50	51

51 // Scroll down 1 tick (40px).	52 // Scroll down 1 tick (40px).

52 eventSender.mouseMoveTo(20, 20);	53 eventSender.mouseMoveTo(20, 20);

53 eventSender.mouseScrollBy(0, -1);	54 eventSender.mouseScrollBy(0, -1);

54	55

55 requestAnimationFrame(runTest);	56 requestAnimationFrame(runTest);

56 }	57 }

57 </script>	58 </script>

OLD	NEW