Make sure scheduler shutdown prevents idle tasks from running

Make sure scheduler shutdown prevents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
Committed: https://crrev.com/00da829b00a5eb879e8f12e2ecf1b97c81dd8088
Cr-Commit-Position: refs/heads/master@{#431241}

[alex clarke (OOO till 29th), 2016-11-10 12:38:58]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 12:39:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-11-10 12:39:14]

alexclarke@chromium.org changed reviewers:
+ altimin@chromium.org, skyostil@chromium.org

[altimin, 2016-11-10 12:47:17]

lgtm

[alex clarke (OOO till 29th), 2016-11-10 13:30:40]

Description was changed from

==========
Make sure scheduler shutdown previents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
==========

to

==========
Make sure scheduler shutdown previents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
==========

[alex clarke (OOO till 29th), 2016-11-10 13:30:50]

Description was changed from

==========
Make sure scheduler shutdown previents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
==========

to

==========
Make sure scheduler shutdown prevents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
==========

[alex clarke (OOO till 29th), 2016-11-10 13:30:55]

The CQ bit was unchecked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-11-10 13:30:57]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2016-11-10 13:31:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 13:46:49]

Description was changed from

==========
Make sure scheduler shutdown prevents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
==========

to

==========
Make sure scheduler shutdown prevents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
==========

[commit-bot: I haz the power, 2016-11-10 13:46:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 13:48:40]

Description was changed from

==========
Make sure scheduler shutdown prevents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081
==========

to

==========
Make sure scheduler shutdown prevents idle tasks from running

It looks like a pending delayed IdleHelper::EnableLongIdlePeriod task
was able to sneak in between shutting the scheduler and blink down
and deleting the message loop (which runs up to 100 tasks) resulting
in a UAF when trying to run ThreadState::scheduleIdleLazySweep.

This patch adds a hard shutdown to the idle helper.

BUG=664081

Committed: https://crrev.com/00da829b00a5eb879e8f12e2ecf1b97c81dd8088
Cr-Commit-Position: refs/heads/master@{#431241}
==========

[commit-bot: I haz the power, 2016-11-10 13:48:41]

Patchset 2 (id:??) landed as
https://crrev.com/00da829b00a5eb879e8f12e2ecf1b97c81dd8088
Cr-Commit-Position: refs/heads/master@{#431241}