third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc - Issue 2487343004: Make sure scheduler shutdown prevents idle tasks from running

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2487343004: Make sure scheduler shutdown prevents idle tasks from running (Closed)

Patch Set: Added a test which fails without the patch. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

index fe93fae460e82ad5d111257952324456d15e5176..752283a0a15a014af36919e419a720257dbc79b0 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

@@ -220,6 +220,7 @@ void RendererSchedulerImpl::Shutdown() {

task_queue_throttler_.reset();

helper_.Shutdown();

+ idle_helper_.Shutdown();

MainThreadOnly().was_shutdown = true;

MainThreadOnly().rail_mode_observer = nullptr;

}

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/child/idle_helper_unittest.cc ('k') | no next file » | no next file with comments »