Adding isolate script targets for all remaining C++ perf tests.

Adding isolate script targets for all remaining C++ perf tests.

BUG=chromium:663372
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d3e023c1b8f23fd56ba75a991bd638dd73e4ccd1
Cr-Commit-Position: refs/heads/master@{#431924}

[eyaich1, 2016-11-09 18:14:27]

Description was changed from

==========
Adding isolate script targets for all remaining C++ perf tests.

BUG=chromium:663372
==========

to

==========
Adding isolate script targets for all remaining C++ perf tests.

BUG=chromium:663372
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[eyaich1, 2016-11-09 18:17:36]

eyaich@chromium.org changed reviewers:
+ dpranke@chromium.org, dtu@chromium.org

[eyaich1, 2016-11-09 18:17:36]

+ jbauman@ for ownership in component/tracing and gpu/

[Dirk Pranke, 2016-11-10 00:26:18]

lgtm

https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:2982: ]
We should create a common target or targets in //testing for these files and
just depend on that, I think.

https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:2983: }
Later, in a separate patch, can we move these targets out of //chrome/test and
closer to the targets that we're actually testing? There's no need (or really,
reason) for these to live here.

[eyaich1, 2016-11-10 15:11:27]

https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:2982: ]
On 2016/11/10 00:26:18, Dirk Pranke wrote:
> We should create a common target or targets in //testing for these files and
> just depend on that, I think.

Since this references something in tools/perf we can't put it in testing, so I
am not sure what a common place for this to live would be besides here where the
gn_isolate_map.py can easily reference it.  

I think we could create a group in this file that clumps them once, similar to
what was started in https://codereview.chromium.org/2456793003/ but never
checked in.  I think that is our best bet.

https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:2983: }
On 2016/11/10 00:26:18, Dirk Pranke wrote:
> Later, in a separate patch, can we move these targets out of //chrome/test and
> closer to the targets that we're actually testing? There's no need (or really,
> reason) for these to live here.

The problem is angle_perftests lives in third_party and we wouldn't be able to
reference the //testing and //tools targets, so we have to aggregate that
somewhere.

[dtu, 2016-11-10 16:43:47]

lgtm

[jbauman, 2016-11-10 20:03:05]

jbauman@chromium.org changed reviewers:
+ jbauman@chromium.org

[jbauman, 2016-11-10 20:03:06]

lgtm

[Dirk Pranke, 2016-11-10 22:25:32]

On 2016/11/10 15:11:27, eyaich1 wrote:
> https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn
> File chrome/test/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2487283002/diff/1/chrome/test/BUILD.gn#newcod...
> chrome/test/BUILD.gn:2982: ]
> On 2016/11/10 00:26:18, Dirk Pranke wrote:
> > We should create a common target or targets in //testing for these files and
> > just depend on that, I think.
> 
> Since this references something in tools/perf we can't put it in testing

Why do you think //testing can't depend on //tools/perf ? I wouldn't have
any objection to this (or from making //tools/perf depend on //testing).

> The problem is angle_perftests lives in third_party and we wouldn't be able to
> reference the //testing and //tools targets, so we have to aggregate that
> somewhere.

//third_party/angle/src/tests already depends on //testing :). We could probably
add a 
dependency on //tools if we really need to, as well.

[eyaich1, 2016-11-14 13:37:43]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-11-14 13:37:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 13:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 13:49:08]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[eyaich1, 2016-11-14 14:04:49]

The CQ bit was checked by eyaich@chromium.org

[eyaich1, 2016-11-14 14:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dtu@chromium.org, jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2487283002/#ps40001
(title: "Correct formattting in GN file")

[commit-bot: I haz the power, 2016-11-14 14:05:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 22:41:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-14 22:58:46]

Description was changed from

==========
Adding isolate script targets for all remaining C++ perf tests.

BUG=chromium:663372
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Adding isolate script targets for all remaining C++ perf tests.

BUG=chromium:663372
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d3e023c1b8f23fd56ba75a991bd638dd73e4ccd1
Cr-Commit-Position: refs/heads/master@{#431924}
==========

[commit-bot: I haz the power, 2016-11-14 22:58:47]

Patchset 3 (id:??) landed as
https://crrev.com/d3e023c1b8f23fd56ba75a991bd638dd73e4ccd1
Cr-Commit-Position: refs/heads/master@{#431924}