Adding isolate script targets for all remaining C++ perf tests.

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/common/features.gni")
@@ skipping 2899 matching lines @@
       deps += [
         "//chrome/browser:pepper_cdm_test_constants",
         "//media:cdm_paths",
       ]
       data_deps = [
         "//media/cdm/ppapi:clearkeycdmadapter",
         "//third_party/widevine/cdm:widevinecdmadapter",
       ]
     }
 
+    data = [
+      # Needed for isolate script to execute.
+      "//testing/scripts/common.py",
+      "//testing/xvfb.py",
+      "//testing/scripts/run_gtest_perf_test.py",
+      "//tools/perf/generate_legacy_perf_dashboard_json.py",
+    ]
+
     # This target should not require the Chrome executable to run.
     assert_no_deps = [ "//chrome" ]
   }
 }
 
 # TODO(GYP_GONE): Delete this after we've converted everything to GN.
 # The _run targets exist only for compatibility w/ GYP.
 group("telemetry_perf_unittests_run") {
   testonly = true
   deps = [
@@ skipping 22 matching lines @@
   ]
 
   data = [
     # Needed for isolate script to execute.
     "//testing/scripts/common.py",
     "//testing/xvfb.py",
     "//testing/scripts/run_telemetry_benchmark_as_googletest.py",
   ]
 }
 
+group("angle_perftests") {
+  testonly = true
+  data_deps = [
+    "//third_party/angle/src/tests:angle_perftests",
+  ]
+
+  data = [
+    # Needed for isolate script to execute.
+    "//testing/scripts/common.py",
+    "//testing/xvfb.py",
+    "//testing/scripts/run_gtest_perf_test.py",
+    "//tools/perf/generate_legacy_perf_dashboard_json.py",
+  ]

[Dirk Pranke, 2016/11/10 00:26:18]

We should create a common target or targets in //testing for these files and
just depend on that, I think.

[eyaich1, 2016/11/10 15:11:27]

Since this references something in tools/perf we can't put it in testing, so I
am not sure what a common place for this to live would be besides here where the
gn_isolate_map.py can easily reference it.  

I think we could create a group in this file that clumps them once, similar to
what was started in https://codereview.chromium.org/2456793003/ but never
checked in.  I think that is our best bet.

+}

[Dirk Pranke, 2016/11/10 00:26:18]

Later, in a separate patch, can we move these targets out of //chrome/test and
closer to the targets that we're actually testing? There's no need (or really,
reason) for these to live here.

[eyaich1, 2016/11/10 15:11:27]

The problem is angle_perftests lives in third_party and we wouldn't be able to
reference the //testing and //tools targets, so we have to aggregate that
somewhere.

+
 js2gtest("unit_tests_js") {
   test_type = "unit"
   sources = [
     "../browser/resources/google_now/background_unittest.gtestjs",
     "../browser/resources/google_now/cards_unittest.gtestjs",
     "../browser/resources/google_now/utility_unittest.gtestjs",
     "../browser/resources/md_downloads/action_service_unittest.gtestjs",
     "../browser/resources/print_preview/data/measurement_system_unittest.gtestjs",
     "../browser/resources/print_preview/print_preview_utils_unittest.gtestjs",
     "../renderer/resources/extensions/notifications_custom_bindings.gtestjs",
@@ skipping 1994 matching lines @@
       "//chrome/renderer",
       "//components/about_handler",
       "//components/autofill/content/renderer:test_support",
       "//content/test:test_support",
       "//media/cast:test_support",
       "//testing/gmock",
       "//testing/gtest",
       "//testing/perf",
     ]
 
+    data = [
+      # Needed for isolate script to execute.
+      "//testing/scripts/common.py",
+      "//testing/xvfb.py",
+      "//testing/scripts/run_gtest_perf_test.py",
+      "//tools/perf/generate_legacy_perf_dashboard_json.py",
+    ]
+
     if (is_win) {
       configs -= [ "//build/config/win:default_incremental_linking" ]
       configs +=
           [ "//build/config/win:default_large_module_incremental_linking" ]
       deps += [ "//chrome/app:command_ids" ]
     } else {
       sources -= [ "../app/chrome_version.rc.version" ]
     }
     if (!is_mac) {
       sources -= [ "perf/mach_ports_performancetest.cc" ]
@@ skipping 69 matching lines @@
       "touch_hud",
       "ui",
     ]
 
     if (is_linux && !is_android) {
       deps += [ "//components/font_service:manifest" ]
       packaged_services += [ "font_service" ]
     }
   }
 }