Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2487133003: Remove dead code related to media device enumerations and monitoring. (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code related to media device enumerations and monitoring. This is the final CL in the migration to Mojo for this functionality. BUG=648183 Make Pepper use Mojo-based support for media-device enumeration and monitoring. BUG=648183 Committed: https://crrev.com/85000e1ea2df05933a6f85c311f6a68f996e78a4 Cr-Commit-Position: refs/heads/master@{#432208}

Patch Set 1 : rebase #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1185 lines) Patch
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_devices_manager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 6 chunks +4 lines, -38 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 7 chunks +3 lines, -136 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 6 chunks +1 line, -106 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 9 chunks +2 lines, -54 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 16 chunks +3 lines, -296 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager_unittest.cc View 3 chunks +1 line, -128 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_requester.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_unittest.cc View 3 chunks +31 lines, -25 lines 0 comments Download
M content/common/media/media_stream_messages.h View 4 chunks +0 lines, -26 lines 0 comments Download
M content/common/media/media_stream_options.h View 2 chunks +2 lines, -7 lines 0 comments Download
M content/common/media/media_stream_options.cc View 1 chunk +1 line, -11 lines 0 comments Download
M content/public/common/media_stream_request.h View 4 chunks +0 lines, -17 lines 0 comments Download
M content/public/common/media_stream_request.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 5 chunks +0 lines, -33 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 6 chunks +1 line, -107 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_eventhandler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 9 chunks +16 lines, -70 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 3 chunks +0 lines, -17 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 4 chunks +0 lines, -26 lines 0 comments Download
M content/renderer/media/mock_media_stream_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/user_media_client_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_device_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_media_device_manager.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
Guido Urdaneta
tommi@chromium.org: Please review content/*/media mkwst@chromium.org: Please review changes in content/common/media/media_stream_messages.h bbudge@chromium.org: Please review changes in ...
4 years, 1 month ago (2016-11-10 11:39:43 UTC) #9
Mike West
Deleting IPC ~always LGTM. \o/
4 years, 1 month ago (2016-11-10 12:34:39 UTC) #12
tommi (sloooow) - chröme
nice! lgtm
4 years, 1 month ago (2016-11-10 13:24:59 UTC) #13
bbudge
Pepper lgtm
4 years, 1 month ago (2016-11-10 18:14:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487133003/40001
4 years, 1 month ago (2016-11-14 09:34:38 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/303256)
4 years, 1 month ago (2016-11-14 09:42:51 UTC) #19
Guido Urdaneta
avi@: Can you rs?
4 years, 1 month ago (2016-11-14 10:28:48 UTC) #22
Guido Urdaneta
avi@chromium.org: can you rs?
4 years, 1 month ago (2016-11-15 07:20:12 UTC) #23
Avi (use Gerrit)
lgtm Stampity stamp
4 years, 1 month ago (2016-11-15 16:22:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487133003/40001
4 years, 1 month ago (2016-11-15 16:25:17 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-15 17:30:19 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 18:02:19 UTC) #30
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85000e1ea2df05933a6f85c311f6a68f996e78a4
Cr-Commit-Position: refs/heads/master@{#432208}

Powered by Google App Engine
This is Rietveld 408576698