Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: content/browser/renderer_host/media/media_devices_manager.cc

Issue 2487133003: Remove dead code related to media device enumerations and monitoring. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_devices_manager.cc
diff --git a/content/browser/renderer_host/media/media_devices_manager.cc b/content/browser/renderer_host/media/media_devices_manager.cc
index c5deb94fd5870a8c6370750b52712fcaf89c699e..8f85f5ced95d64228031c660bd036c89da6156e4 100644
--- a/content/browser/renderer_host/media/media_devices_manager.cc
+++ b/content/browser/renderer_host/media/media_devices_manager.cc
@@ -525,19 +525,6 @@ void MediaDevicesManager::NotifyDeviceChangeSubscribers(
DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(IsValidMediaDeviceType(type));
- // TODO(guidou): Use device types instead of stream types, and remove the
- // call to MediaStreamManager once handling of device-change subscriptions
- // is removed from MediaStreamManager. See http://crbug.com/334244.
- // |permission_type| is used by MediaStreamManager to decide which permission
- // to check before forwarding the event to the renderer process. Since there
- // is no separate permission for audio output devices yet, use
- // MEDIA_DEVICE_AUDIO_CAPTURE for both audio input and output.
- MediaStreamType permission_type = type == MEDIA_DEVICE_TYPE_VIDEO_INPUT
- ? MEDIA_DEVICE_VIDEO_CAPTURE
- : MEDIA_DEVICE_AUDIO_CAPTURE;
- if (media_stream_manager_)
- media_stream_manager_->NotifyDeviceChangeSubscribers(permission_type);
-
for (const auto& subscriber : device_change_subscribers_[type]) {
subscriber->OnDevicesChanged(type, snapshot);
}

Powered by Google App Engine
This is Rietveld 408576698